You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Nikhil P <ni...@gmail.com> on 2018/03/06 13:22:01 UTC
Review Request 65925: HDFS resource delegation improvement
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65925/
-----------------------------------------------------------
Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
Bugs: RANGER-2009
https://issues.apache.org/jira/browse/RANGER-2009
Repository: ranger
Description
-------
HDFS resource delegation improvement
Diffs
-----
agents-common/src/main/java/org/apache/ranger/plugin/resourcematcher/RangerPathResourceMatcher.java 78a3b8a
Diff: https://reviews.apache.org/r/65925/diff/1/
Testing
-------
Tested for various HDFS resources such as wildcard, non wildcard resources.
Thanks,
Nikhil P
Re: Review Request 65925: HDFS resource delegation improvement
Posted by Zsombor Gegesy <zs...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65925/#review198694
-----------------------------------------------------------
Could you add a small unit test for it ? At least for the method.
- Zsombor Gegesy
On March 6, 2018, 1:22 p.m., Nikhil P wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65925/
> -----------------------------------------------------------
>
> (Updated March 6, 2018, 1:22 p.m.)
>
>
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-2009
> https://issues.apache.org/jira/browse/RANGER-2009
>
>
> Repository: ranger
>
>
> Description
> -------
>
> HDFS resource delegation improvement
>
>
> Diffs
> -----
>
> agents-common/src/main/java/org/apache/ranger/plugin/resourcematcher/RangerPathResourceMatcher.java 78a3b8a
>
>
> Diff: https://reviews.apache.org/r/65925/diff/1/
>
>
> Testing
> -------
>
> Tested for various HDFS resources such as wildcard, non wildcard resources.
>
>
> Thanks,
>
> Nikhil P
>
>
Re: Review Request 65925: HDFS resource delegation improvement
Posted by Velmurugan Periasamy <vp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65925/#review198739
-----------------------------------------------------------
agents-common/src/main/java/org/apache/ranger/plugin/resourcematcher/RangerPathResourceMatcher.java
Lines 157 (patched)
<https://reviews.apache.org/r/65925/#comment278966>
This patch is failing existing unit tests. Please fix and add new test for the method.
```
[INFO] Running org.apache.ranger.plugin.resourcematcher.TestResourceMatcher
[ERROR] Tests run: 4, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.006 s <<< FAILURE! - in org.apache.ranger.plugin.resourcematcher.TestResourceMatcher
[ERROR] testResourceMatcher_path(org.apache.ranger.plugin.resourcematcher.TestResourceMatcher) Time elapsed: 0.003 s <<< FAILURE!
java.lang.AssertionError: isMatch() failed! Case 0:value=/home/; isRecursive=true; wildCard=true; ignoreCase=true:seemingly-correct-path: input=/home/ expected:<false> but was:<true>
at org.apache.ranger.plugin.resourcematcher.TestResourceMatcher.runTests(TestResourceMatcher.java:117)
at org.apache.ranger.plugin.resourcematcher.TestResourceMatcher.runTestsFromResourceFiles(TestResourceMatcher.java:97)
at org.apache.ranger.plugin.resourcematcher.TestResourceMatcher.testResourceMatcher_path(TestResourceMatcher.java:75)
[INFO] Running org.apache.ranger.plugin.util.PasswordUtilsTest
[INFO] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.151 s - in org.apache.ranger.plugin.util.PasswordUtilsTest
[INFO]
[INFO] Results:
[INFO]
[ERROR] Failures:
[ERROR] TestPolicyEngine.testValiditySchedularApplicable:553->runValiditySchedulerTests:596 Applicable every Wednesday or Saturday or 1st of month starting at 10 past noon hour PST for 2 days and 10 hours
[ERROR] TestPolicyEngine.testValiditySchedularValid:546->runValiditySchedulerTests:596 dayOfWeek blank and dayOfMonth not blank
[ERROR] TestResourceMatcher.testResourceMatcher_path:75->runTestsFromResourceFiles:97->runTests:117 isMatch() failed! Case 0:value=/home/; isRecursive=true; wildCard=true; ignoreCase=true:seemingly-correct-path: input=/home/ expected:<false> but was:<true>
```
- Velmurugan Periasamy
On March 6, 2018, 1:22 p.m., Nikhil P wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65925/
> -----------------------------------------------------------
>
> (Updated March 6, 2018, 1:22 p.m.)
>
>
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-2009
> https://issues.apache.org/jira/browse/RANGER-2009
>
>
> Repository: ranger
>
>
> Description
> -------
>
> HDFS resource delegation improvement
>
>
> Diffs
> -----
>
> agents-common/src/main/java/org/apache/ranger/plugin/resourcematcher/RangerPathResourceMatcher.java 78a3b8a
>
>
> Diff: https://reviews.apache.org/r/65925/diff/1/
>
>
> Testing
> -------
>
> Tested for various HDFS resources such as wildcard, non wildcard resources.
>
>
> Thanks,
>
> Nikhil P
>
>