[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #8425: tools: Fix Config.mk

["xiaoxiang781216 (via GitHub)" <gi...@apache.org>]

xiaoxiang781216 commented on code in PR #8425:
URL: https://github.com/apache/nuttx/pull/8425#discussion_r1095861055


##########
tools/Config.mk:
##########
@@ -42,13 +42,13 @@ else ifeq ($(V),)
   BASHCMD := $(shell command -v bash 2> /dev/null)
   ifneq ($(BASHCMD),)
     export SHELL=$(BASHCMD)
-    export ECHO_BEGIN=@echo -ne "\033[1K\r"
+    export ECHO_BEGIN=@echo " " -ne "\033[1K\r"
     export ECHO_END=$(ECHO_BEGIN)
   endif
 endif
 
 ifeq ($(ECHO_BEGIN),)
-  export ECHO_BEGIN=@echo
+  export ECHO_BEGIN=@echo " "

Review Comment:
   can we add space in caller site? like this:
   $(ECHO_BEGIN) "CPP: $1->$2"



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org