You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by saleyn <gi...@git.apache.org> on 2015/06/09 17:51:46 UTC
[GitHub] thrift pull request: Add UNIX Domain Socket support
GitHub user saleyn opened a pull request:
https://github.com/apache/thrift/pull/516
Add UNIX Domain Socket support
Non-blocking server support for listening on unix domain sockets (UDS).
Add UDS support to Erlang client
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/saleyn/thrift uds
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/516.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #516
----
commit dedcc2911d223f832f8c25629bb2b05a4ef35eba
Author: Serge Aleynikov <sa...@gmail.com>
Date: 2014-02-11T01:02:09Z
Support non-blocking server listening on unix domain sockets
commit e1888d434fce3b33a40052a28c732c1c3899a54c
Author: Serge Aleynikov <sa...@gmail.com>
Date: 2014-03-27T01:02:39Z
Archlinux build fix
commit e3c4b41e7ea5180b377419441a78178dd84cb16e
Author: Serge Aleynikov <sa...@gmail.com>
Date: 2014-03-27T02:07:01Z
Archlinux build fix
commit b064f00feb1f5cad80d4e3e54d2e0ca7f12399c5
Author: Serge Aleynikov <sa...@gmail.com>
Date: 2015-06-09T15:05:23Z
Add support for UNIX Domain Sockets to erl
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: Add UNIX Domain Socket support
Posted by jfarrell <gi...@git.apache.org>.
Github user jfarrell commented on the pull request:
https://github.com/apache/thrift/pull/516#issuecomment-140739419
Thanks, I like that you have submitted euds upstream, would be nice to not have that as a dependency and just use it natively. Is there any traction on that pull request to OTP?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift issue #516: Add UNIX Domain Socket support
Posted by saleyn <gi...@git.apache.org>.
Github user saleyn commented on the issue:
https://github.com/apache/thrift/pull/516
If I get spare time for this I'll migrate this to using the native Unix Domain Sockets support in Erlang. Though I no longer use Thrift, and currently for me this is a very low priority.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: Add UNIX Domain Socket support
Posted by jfarrell <gi...@git.apache.org>.
Github user jfarrell commented on the pull request:
https://github.com/apache/thrift/pull/516#issuecomment-140596216
hey @saleyn, thanks for the patch. We try to keep our dependencies to a minimum to make it easier for the client libraries to be integrated into a wide variety of projects. One quick thing i see with this patch is that euds does not have a license, which makes it a little harder for us to even look at integrating with Apache Thrift. Can the same result be achieved using native support without too much additional lifting?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift issue #516: Add UNIX Domain Socket support
Posted by jeking3 <gi...@git.apache.org>.
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/516
@jfarrell recommend closing this PR. It never got a thrift ticket, and has an external dependency to a library that has been discontinued:
```
UPDATE: this project will be deprecated beginning with Erlang 19RC2, which will include native support for Unix Domain Sockets.
```
Any implementation of unix sockets for erlang would need to be re-done at this point. I opened a wish ticket in Jira for this: THRIFT-4169
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: Add UNIX Domain Socket support
Posted by saleyn <gi...@git.apache.org>.
Github user saleyn commented on the pull request:
https://github.com/apache/thrift/pull/516#issuecomment-140734606
I will add a license file. Would Apache 2.0 license do?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request #516: Add UNIX Domain Socket support
Posted by saleyn <gi...@git.apache.org>.
Github user saleyn closed the pull request at:
https://github.com/apache/thrift/pull/516
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: Add UNIX Domain Socket support
Posted by saleyn <gi...@git.apache.org>.
Github user saleyn commented on the pull request:
https://github.com/apache/thrift/pull/516#issuecomment-141050695
The latest I heard it was put on the Raimo's (from the OTP team) plate of things to do. Hopefully he'll manage to get it done in the next several months. It's a shame OTP is missing native support for UDS - likely a design oversight, but I am certain it'll get done as people express strong support for addressing the issue (through my patch or its derivative).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---