You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@jmeter.apache.org by mgashraf <gi...@git.apache.org> on 2017/02/23 11:24:59 UTC

[GitHub] jmeter pull request #277: Bug 58506 - JMS Point-to-point sampler should offe...

GitHub user mgashraf opened a pull request:

    https://github.com/apache/jmeter/pull/277

    Bug 58506 - JMS Point-to-point sampler should offer an async using temp queue mode and prevent hangs by supporting a reply timeout

    Bug 58506 - JMS Point-to-point sampler should offer an async using temp queue mode and prevent hangs by supporting a reply timeout.
    
    Changed line 'executor = new ExtendedTemporaryQueueExecutor(session, sendQueue, getTimeoutAsInt());'
    to accept timeout.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mgashraf/jmeter trunk

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/jmeter/pull/277.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #277
    
----
commit c399502f97bfbc4245fd31c21dc04da7d8a08664
Author: Ashraf <mg...@outlook.com>
Date:   2017-02-23T11:18:59Z

    Added timeout for TemporaryQueueExecutor to timeout when user just passes the request queue. This is for
    Bug 58506 - JMS Point-to-point sampler should offer an async using temp queue mode and prevent hangs by supporting a reply timeout

commit 902d11aee4a8353cb3f0b07ece1a796894e56458
Author: Ashraf <mg...@outlook.com>
Date:   2017-02-23T11:22:58Z

    Update JMSSampler.java

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] jmeter issue #277: Bug 58506 - JMS Point-to-point sampler should offer an as...

Posted by mgashraf <gi...@git.apache.org>.

Github user mgashraf commented on the issue:

    https://github.com/apache/jmeter/pull/277
  
    Hello @pmouawad,
    Could you please review the changes. We need to have this functionality as part of our project.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] jmeter pull request #277: Bug 58506 - JMS Point-to-point sampler should offe...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/jmeter/pull/277


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] jmeter issue #277: Bug 58506 - JMS Point-to-point sampler should offer an as...

Posted by pmouawad <gi...@git.apache.org>.

Github user pmouawad commented on the issue:

    https://github.com/apache/jmeter/pull/277
  
    Hello,
    Thank you for your contribution.
    My notes:
    - The class ExtendedQueueRequestor seems to come from existing code as per "This source code implements specifications defined by the Java Community Process." Are you the author of this code or not ? If not what is the license of this code ?
    - The code lacks javadoc for  ExtendedQueueRequestor
    - TemporaryQueueExecutor is not used anymore, it should be deprecated
    - The ExtendedQueueRequestor needs to be unit tested. Since we've setup Sonar on repository, we try to increase test coverage either with JUnit code or Test Plan that allows testing results. This code should be unit tested using mocks I think
    
    Regards


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---