You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/10/26 06:18:54 UTC
[GitHub] [airflow] codecov-io commented on issue #6383: [AIRFLOW-5711] Add
fallback for connection's project ID in Dataflow integration
codecov-io commented on issue #6383: [AIRFLOW-5711] Add fallback for connection's project ID in Dataflow integration
URL: https://github.com/apache/airflow/pull/6383#issuecomment-546574504
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6383?src=pr&el=h1) Report
> Merging [#6383](https://codecov.io/gh/apache/airflow/pull/6383?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/74d2a0d9e77cf90b85654f65d1adba0875e0fb1f?src=pr&el=desc) will **increase** coverage by `3.37%`.
> The diff coverage is `95.23%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/6383/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/airflow/pull/6383?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6383 +/- ##
==========================================
+ Coverage 80.59% 83.97% +3.37%
==========================================
Files 626 627 +1
Lines 36243 36541 +298
==========================================
+ Hits 29211 30684 +1473
+ Misses 7032 5857 -1175
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6383?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/gcp/operators/dataflow.py](https://codecov.io/gh/apache/airflow/pull/6383/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3Avb3BlcmF0b3JzL2RhdGFmbG93LnB5) | `99.07% <75%> (ø)` | :arrow_up: |
| [airflow/gcp/hooks/dataflow.py](https://codecov.io/gh/apache/airflow/pull/6383/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvZGF0YWZsb3cucHk=) | `92.24% <97.36%> (+1.08%)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6383/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6383/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6383/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/kube\_client.py](https://codecov.io/gh/apache/airflow/pull/6383/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL2t1YmVfY2xpZW50LnB5) | `33.33% <0%> (-41.67%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6383/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `70.14% <0%> (-28.36%)` | :arrow_down: |
| [airflow/models/dagbag.py](https://codecov.io/gh/apache/airflow/pull/6383/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvZGFnYmFnLnB5) | `85.24% <0%> (-7.18%)` | :arrow_down: |
| [airflow/example\_dags/example\_trigger\_target\_dag.py](https://codecov.io/gh/apache/airflow/pull/6383/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV90cmlnZ2VyX3RhcmdldF9kYWcucHk=) | `90% <0%> (-2.31%)` | :arrow_down: |
| [airflow/api/common/experimental/delete\_dag.py](https://codecov.io/gh/apache/airflow/pull/6383/diff?src=pr&el=tree#diff-YWlyZmxvdy9hcGkvY29tbW9uL2V4cGVyaW1lbnRhbC9kZWxldGVfZGFnLnB5) | `86.66% <0%> (-0.84%)` | :arrow_down: |
| ... and [86 more](https://codecov.io/gh/apache/airflow/pull/6383/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6383?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6383?src=pr&el=footer). Last update [74d2a0d...1d24daf](https://codecov.io/gh/apache/airflow/pull/6383?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services