You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by gengliangwang <gi...@git.apache.org> on 2018/08/13 08:54:04 UTC
[GitHub] spark pull request #22091: [SPARK-25099][SQL][TEST] Generate Avro Binary fil...
GitHub user gengliangwang opened a pull request:
https://github.com/apache/spark/pull/22091
[SPARK-25099][SQL][TEST] Generate Avro Binary files in test suite
## What changes were proposed in this pull request?
In PR https://github.com/apache/spark/pull/21984 and https://github.com/apache/spark/pull/21935 , the related test cases are using binary files created by Python scripts.
Generate the binary files in test suite to make it more transparent. Also we can
Also move the related test cases to a new file `AvroLogicalTypeSuite.scala`.
## How was this patch tested?
Unit test.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gengliangwang/spark logicalType_suite
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/22091.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #22091
----
commit 373777b5404c8feffe75a08bd72e5a48c45dae61
Author: Gengliang Wang <ge...@...>
Date: 2018-08-13T08:41:33Z
create AvroLogicalTypeSuite
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22091: [SPARK-25099][SQL][TEST] Generate Avro Binary files in t...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22091
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22091: [SPARK-25099][SQL][TEST] Generate Avro Binary files in t...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22091
**[Test build #94682 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94682/testReport)** for PR 22091 at commit [`373777b`](https://github.com/apache/spark/commit/373777b5404c8feffe75a08bd72e5a48c45dae61).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #22091: [SPARK-25099][SQL][TEST] Generate Avro Binary fil...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/22091
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22091: [SPARK-25099][SQL][TEST] Generate Avro Binary files in t...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22091
**[Test build #94682 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94682/testReport)** for PR 22091 at commit [`373777b`](https://github.com/apache/spark/commit/373777b5404c8feffe75a08bd72e5a48c45dae61).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `class AvroLogicalTypeSuite extends QueryTest with SharedSQLContext with SQLTestUtils `
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22091: [SPARK-25099][SQL][TEST] Generate Avro Binary files in t...
Posted by cloud-fan <gi...@git.apache.org>.
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/22091
LGTM, merging to master!
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22091: [SPARK-25099][SQL][TEST] Generate Avro Binary files in t...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22091
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22091: [SPARK-25099][SQL][TEST] Generate Avro Binary files in t...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22091
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94682/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22091: [SPARK-25099][SQL][TEST] Generate Avro Binary files in t...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22091
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/2127/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org