You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by Konstantin Kolinko <kn...@gmail.com> on 2011/06/19 02:15:26 UTC

Diagram for AsyncStateMachine.java

Hi, all!

I have redrawn the state diagram for trunk's
org/apache/coyote/AsyncStateMachine.java.

It is here:
http://people.apache.org/~kkolinko/patches/AsyncStateMachine.txt

It matches the current diagram that is included in
AsyncStateMachine.java JavaDoc, @rev.1137246.
I am not committing it yet.

Feel free to enjoy and comment.

Best regards,
Konstantin Kolinko

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

Re: Diagram for AsyncStateMachine.java

Posted by Konstantin Kolinko <kn...@gmail.com>.
2011/6/19 Mark Thomas <ma...@apache.org>:
> On 19/06/2011 01:15, Konstantin Kolinko wrote:
>> I have redrawn the state diagram for trunk's
>> org/apache/coyote/AsyncStateMachine.java.
>
> Why?

I was trying to understand the logic behind the states and
similarities between them, without looking too much in the code or in
the spec yet.

In my version of the diagram the events are arranged so that
postProcess() transition always goes from the right to the left. That
is why STARTING state was moved to the right.


Best regards,
Konstantin Kolinko

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

Re: Diagram for AsyncStateMachine.java

Posted by Mark Thomas <ma...@apache.org>.
On 19/06/2011 01:15, Konstantin Kolinko wrote:
> Hi, all!
> 
> I have redrawn the state diagram for trunk's
> org/apache/coyote/AsyncStateMachine.java.

Why?

> It is here:
> http://people.apache.org/~kkolinko/patches/AsyncStateMachine.txt
> 
> It matches the current diagram that is included in
> AsyncStateMachine.java JavaDoc, @rev.1137246.
> I am not committing it yet.
> 
> Feel free to enjoy and comment.

I'm not against a re-draw.

- I like the use of \ and / on the corners
- I like that it is more compact
- I like the addition of new
- I don't like that there are more cross-overs (I'd prefer none but I
don't think that is possible)
- I don't like that STARTING is out of line with DISPATCHED and STARTED

Mark



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

Re: Diagram for AsyncStateMachine.java

Posted by Christopher Schultz <ch...@christopherschultz.net>.
Konstantin,

On 6/18/2011 8:15 PM, Konstantin Kolinko wrote:
> I have redrawn the state diagram for trunk's
> org/apache/coyote/AsyncStateMachine.java.

Would it be worth including the state transitions in
AsyncStateMachine.java in "dot" format for rendering in GraphViz?

-chris