You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "rishabhdaim (via GitHub)" <gi...@apache.org> on 2023/07/22 05:48:17 UTC
[GitHub] [sling-org-apache-sling-jcr-contentloader] rishabhdaim opened a new pull request, #25: SLING-11894 : fixed IT test failures on JDK 17
rishabhdaim opened a new pull request, #25:
URL: https://github.com/apache/sling-org-apache-sling-jcr-contentloader/pull/25
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-jcr-contentloader] stefan-egli commented on pull request #25: SLING-11894 : fixed IT test failures on JDK 17
Posted by "stefan-egli (via GitHub)" <gi...@apache.org>.
stefan-egli commented on PR #25:
URL: https://github.com/apache/sling-org-apache-sling-jcr-contentloader/pull/25#issuecomment-1681785709
merging based on the two reviews
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-jcr-contentloader] sonarcloud[bot] commented on pull request #25: SLING-11894 : fixed IT test failures on JDK 17
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #25:
URL: https://github.com/apache/sling-org-apache-sling-jcr-contentloader/pull/25#issuecomment-1646498921
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-jcr-contentloader&pullRequest=25)
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader&pullRequest=25&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader&pullRequest=25&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader&pullRequest=25&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader&pullRequest=25&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader&pullRequest=25&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader&pullRequest=25&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jcr-contentloader&pullRequest=25&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jcr-contentloader&pullRequest=25&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jcr-contentloader&pullRequest=25&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader&pullRequest=25&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader&pullRequest=25&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader&pullRequest=25&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-contentloader&pullRequest=25&metric=coverage&view=list) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-contentloader&pullRequest=25&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-contentloader&pullRequest=25&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-jcr-contentloader] enapps-enorman commented on a diff in pull request #25: SLING-11894 : fixed IT test failures on JDK 17
Posted by "enapps-enorman (via GitHub)" <gi...@apache.org>.
enapps-enorman commented on code in PR #25:
URL: https://github.com/apache/sling-org-apache-sling-jcr-contentloader/pull/25#discussion_r1294029797
##########
src/test/java/org/apache/sling/jcr/contentloader/it/ContentloaderTestSupport.java:
##########
@@ -39,7 +40,6 @@
import java.io.InputStream;
import java.io.StringWriter;
import java.text.SimpleDateFormat;
-import java.time.Duration;
Review Comment:
Add this back when switching to awaitility 4.x
##########
src/test/java/org/apache/sling/jcr/contentloader/it/ContentloaderTestSupport.java:
##########
@@ -18,6 +18,7 @@
*/
package org.apache.sling.jcr.contentloader.it;
+import static java.util.concurrent.TimeUnit.MILLISECONDS;
Review Comment:
Remove this when switching to awaitility 4.x
##########
pom.xml:
##########
@@ -383,10 +383,11 @@
<version>${org.ops4j.pax.exam.version}</version>
<scope>test</scope>
</dependency>
+ <!-- can't go beyond org.awaitility 3.1.6 because PAX exam 4.0.0 is hard coded to use this-->
Review Comment:
I'm not really sure why o.a.sling.testing.paxexam has changed the awaitility version to the older 3.x version instead of the 4.x version that it used to be.
I think we should try to not go backwards to the 3.x version of awaitility if we can avoid it. I think the syntax of java.time.Duration is more readable than the older syntax of org.awaitility.Duration constructors.
I think that a workaround could be accomplished by providing a custom ContentloaderTestSupport#awaitility method to provide a different implementation that pulls in the latest awaitility library instead of the old one.
Something like this new method in ContentloaderTestSupport should work?
```
/**
* Replacement for {@link SlingOptions#awaitility()} to utilize a newer version of awaitility
*
* NOTE: may remove this at a later date and go back to {@link SlingOptions#awaitility()} whenever
* {@link SlingVersionResolver} provides these versions or later
*/
public static ModifiableCompositeOption awaitility() {
return composite(
mavenBundle().groupId("org.awaitility").artifactId("awaitility").versionAsInProject(),
mavenBundle().groupId("org.hamcrest").artifactId("hamcrest").version(SlingOptions.versionResolver)
);
}
```
##########
pom.xml:
##########
@@ -383,10 +383,11 @@
<version>${org.ops4j.pax.exam.version}</version>
<scope>test</scope>
</dependency>
+ <!-- can't go beyond org.awaitility 3.1.6 because PAX exam 4.0.0 is hard coded to use this-->
<dependency>
<groupId>org.awaitility</groupId>
<artifactId>awaitility</artifactId>
- <version>4.2.0</version>
Review Comment:
I'd like this to go back to the 4.2.0 version if possible.
##########
src/test/java/org/apache/sling/jcr/contentloader/it/ContentloaderTestSupport.java:
##########
@@ -59,6 +59,7 @@
import org.apache.sling.testing.paxexam.SlingOptions;
import org.apache.sling.testing.paxexam.TestSupport;
import org.awaitility.Awaitility;
+import org.awaitility.Duration;
Review Comment:
Remove this when switching to awaitility 4.x
##########
src/test/java/org/apache/sling/jcr/contentloader/it/ContentloaderTestSupport.java:
##########
@@ -18,6 +18,7 @@
*/
package org.apache.sling.jcr.contentloader.it;
+import static java.util.concurrent.TimeUnit.MILLISECONDS;
import static org.apache.felix.hc.api.FormattingResultLog.msHumanReadable;
import static org.apache.sling.testing.paxexam.SlingOptions.awaitility;
Review Comment:
Remove this if using the custom ContentloaderTestSupport#awaitility method instead.
##########
src/test/java/org/apache/sling/jcr/contentloader/it/ContentloaderTestSupport.java:
##########
@@ -196,8 +190,8 @@ protected void waitForContentLoaded() throws Exception {
*/
protected void waitForContentLoaded(long timeoutMsec, long nextIterationDelay) throws Exception {
Awaitility.await("waitForContentLoaded")
- .atMost(Duration.ofMillis(timeoutMsec))
Review Comment:
If switching back to awaitility 4.x then these two changed lines should be reverted back to how it was before.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-jcr-contentloader] sonarcloud[bot] commented on pull request #25: SLING-11894 : fixed IT test failures on JDK 17
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #25:
URL: https://github.com/apache/sling-org-apache-sling-jcr-contentloader/pull/25#issuecomment-1680142113
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-jcr-contentloader&pullRequest=25)
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader&pullRequest=25&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader&pullRequest=25&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader&pullRequest=25&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader&pullRequest=25&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader&pullRequest=25&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader&pullRequest=25&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jcr-contentloader&pullRequest=25&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jcr-contentloader&pullRequest=25&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jcr-contentloader&pullRequest=25&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader&pullRequest=25&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader&pullRequest=25&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader&pullRequest=25&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-contentloader&pullRequest=25&metric=coverage&view=list) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-contentloader&pullRequest=25&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-contentloader&pullRequest=25&metric=new_duplicated_lines_density&view=list)
 The version of Java (11.0.16.1) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more [here](https://docs.sonarcloud.io/appendices/scanner-environment/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-jcr-contentloader] rishabhdaim commented on pull request #25: SLING-11894 : fixed IT test failures on JDK 17
Posted by "rishabhdaim (via GitHub)" <gi...@apache.org>.
rishabhdaim commented on PR #25:
URL: https://github.com/apache/sling-org-apache-sling-jcr-contentloader/pull/25#issuecomment-1646497677
@stefan-egli @stefanseifert could you please review the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-jcr-contentloader] sonarcloud[bot] commented on pull request #25: SLING-11894 : fixed IT test failures on JDK 17
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #25:
URL: https://github.com/apache/sling-org-apache-sling-jcr-contentloader/pull/25#issuecomment-1681210236
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-jcr-contentloader&pullRequest=25)
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader&pullRequest=25&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader&pullRequest=25&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader&pullRequest=25&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader&pullRequest=25&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader&pullRequest=25&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader&pullRequest=25&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jcr-contentloader&pullRequest=25&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jcr-contentloader&pullRequest=25&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-jcr-contentloader&pullRequest=25&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader&pullRequest=25&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader&pullRequest=25&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-jcr-contentloader&pullRequest=25&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-contentloader&pullRequest=25&metric=coverage&view=list) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-contentloader&pullRequest=25&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-jcr-contentloader&pullRequest=25&metric=new_duplicated_lines_density&view=list)
 The version of Java (11.0.16.1) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more [here](https://docs.sonarcloud.io/appendices/scanner-environment/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-jcr-contentloader] stefan-egli merged pull request #25: SLING-11894 : fixed IT test failures on JDK 17
Posted by "stefan-egli (via GitHub)" <gi...@apache.org>.
stefan-egli merged PR #25:
URL: https://github.com/apache/sling-org-apache-sling-jcr-contentloader/pull/25
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org