You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@archiva.apache.org by nicolas de loof <ni...@gmail.com> on 2007/11/14 17:47:52 UTC
regression in beta-4 : server-side relocation broken
MRM-595 created.
As explain, there is two causes :
1. fetchContentFromProxies must be called prior to building the resource
File
2. DavServerRequest getLogicalResource is not re-computed when request
PathInfo changes.
Nico.
Re: regression in beta-4 : server-side relocation broken
Posted by nicolas de loof <ni...@gmail.com>.
I just attached a testcase and a patch to solve MRM-595. This requires some
trivial changes on plexus-webdav-api.
Nico.
2007/11/14, nicolas de loof <ni...@gmail.com>:
>
> Thats right,
>
> I'll first focus on writting such test-cases. This was in my todo list for
> long time :-/
>
> Nico.
>
>
> 2007/11/14, Joakim Erdfelt <jo...@erdfelt.com>:
> >
> > Don't we have unit testing around the server side relocation?
> > If not, I think we need to get them into place as part of the solution
> > for MRM-595.
> >
> > - Joakim
> >
> > nicolas de loof wrote:
> > > MRM-595 created.
> > >
> > > As explain, there is two causes :
> > >
> > > 1. fetchContentFromProxies must be called prior to building the
> > resource
> > > File
> > > 2. DavServerRequest getLogicalResource is not re-computed when request
> > > PathInfo changes.
> > >
> > >
> > > Nico.
> > >
> > >
> >
> >
>
Re: regression in beta-4 : server-side relocation broken
Posted by nicolas de loof <ni...@gmail.com>.
Thats right,
I'll first focus on writting such test-cases. This was in my todo list for
long time :-/
Nico.
2007/11/14, Joakim Erdfelt <jo...@erdfelt.com>:
>
> Don't we have unit testing around the server side relocation?
> If not, I think we need to get them into place as part of the solution
> for MRM-595.
>
> - Joakim
>
> nicolas de loof wrote:
> > MRM-595 created.
> >
> > As explain, there is two causes :
> >
> > 1. fetchContentFromProxies must be called prior to building the resource
> > File
> > 2. DavServerRequest getLogicalResource is not re-computed when request
> > PathInfo changes.
> >
> >
> > Nico.
> >
> >
>
>
Re: regression in beta-4 : server-side relocation broken
Posted by Joakim Erdfelt <jo...@erdfelt.com>.
A little bit too much of a coincidence that you should also be having a
relocation related problem.
I'll see what I can do to get some unit testing around this into place
on the RepositoryServlet tests.
- Joakim
Arnaud HERITIER wrote:
> I noticed a problem when I tested this version before the vote but i didn't
> find the time to check if it was a regression.
> It's with poi:poi:2.5.1 which is relocated to 2.5.1-final-20040804
> I don't know if it can be related to this issue
>
> Arnaud
>
> On Nov 14, 2007 6:20 PM, Joakim Erdfelt <jo...@erdfelt.com> wrote:
>
>
>> Don't we have unit testing around the server side relocation?
>> If not, I think we need to get them into place as part of the solution
>> for MRM-595.
>>
>> - Joakim
>>
>> nicolas de loof wrote:
>>
>>> MRM-595 created.
>>>
>>> As explain, there is two causes :
>>>
>>> 1. fetchContentFromProxies must be called prior to building the resource
>>> File
>>> 2. DavServerRequest getLogicalResource is not re-computed when request
>>> PathInfo changes.
>>>
>>>
>>> Nico.
>>>
>>>
>>>
>>
>
>
>
Re: regression in beta-4 : server-side relocation broken
Posted by Arnaud HERITIER <ah...@gmail.com>.
I noticed a problem when I tested this version before the vote but i didn't
find the time to check if it was a regression.
It's with poi:poi:2.5.1 which is relocated to 2.5.1-final-20040804
I don't know if it can be related to this issue
Arnaud
On Nov 14, 2007 6:20 PM, Joakim Erdfelt <jo...@erdfelt.com> wrote:
> Don't we have unit testing around the server side relocation?
> If not, I think we need to get them into place as part of the solution
> for MRM-595.
>
> - Joakim
>
> nicolas de loof wrote:
> > MRM-595 created.
> >
> > As explain, there is two causes :
> >
> > 1. fetchContentFromProxies must be called prior to building the resource
> > File
> > 2. DavServerRequest getLogicalResource is not re-computed when request
> > PathInfo changes.
> >
> >
> > Nico.
> >
> >
>
>
--
..........................................................
Arnaud HERITIER
..........................................................
OCTO Technology - aheritier AT octo DOT com
www.octo.com | blog.octo.com
..........................................................
ASF - aheritier AT apache DOT org
www.apache.org | maven.apache.org
...........................................................
Re: regression in beta-4 : server-side relocation broken
Posted by Joakim Erdfelt <jo...@erdfelt.com>.
Don't we have unit testing around the server side relocation?
If not, I think we need to get them into place as part of the solution
for MRM-595.
- Joakim
nicolas de loof wrote:
> MRM-595 created.
>
> As explain, there is two causes :
>
> 1. fetchContentFromProxies must be called prior to building the resource
> File
> 2. DavServerRequest getLogicalResource is not re-computed when request
> PathInfo changes.
>
>
> Nico.
>
>