You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "abonander (via GitHub)" <gi...@apache.org> on 2026/06/22 15:56:03 UTC
[PR] feat(Rust): make boolean conventions clearer [arrow-adbc]
abonander opened a new pull request, #4427:
URL: https://github.com/apache/arrow-adbc/pull/4427
Adds `From<bool> for OptionValue` and `TryFrom<OptionValue> for bool` (and `TryFrom<&OptionValue>`).
closes #4413
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(rust): make boolean conventions clearer [arrow-adbc]
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm merged PR #4427:
URL: https://github.com/apache/arrow-adbc/pull/4427
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(Rust): make boolean conventions clearer [arrow-adbc]
Posted by "abonander (via GitHub)" <gi...@apache.org>.
abonander commented on code in PR #4427:
URL: https://github.com/apache/arrow-adbc/pull/4427#discussion_r3453667110
##########
rust/core/src/options.rs:
##########
@@ -18,6 +18,7 @@
//! Various option and configuration types.
use std::{os::raw::c_int, str::FromStr};
+use crate::constants::{ADBC_OPTION_VALUE_DISABLED, ADBC_OPTION_VALUE_ENABLED};
Review Comment:
I see other references to this module are qualified under `constants::` but I felt that would have made the docs unnecessarily noisy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org