You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Avinash sridharan <av...@mesosphere.io> on 2016/04/11 18:04:58 UTC

Review Request 46035: Introduced `exposed_ports` field in `NetworkInfo`.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46035/
-----------------------------------------------------------

Review request for mesos and Jie Yu.


Bugs: MESOS-4823
    https://issues.apache.org/jira/browse/MESOS-4823


Repository: mesos


Description
-------

Frameworks can specify container ports that they want exposed on the
host's network using this field.


Diffs
-----

  include/mesos/mesos.proto e1fc02e05df531e29601c6764a5a48ba2b18569f 
  include/mesos/v1/mesos.proto 35789e051608ea7f1be3ba5b63eaa1fc4e501c84 

Diff: https://reviews.apache.org/r/46035/diff/


Testing
-------

make


Thanks,

Avinash sridharan


Re: Review Request 46035: Introduced `exposed_ports` field in `NetworkInfo`.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46035/#review128703
-----------------------------------------------------------



Patch looks great!

Reviews applied: [46035]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On April 13, 2016, 2:20 p.m., Avinash sridharan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46035/
> -----------------------------------------------------------
> 
> (Updated April 13, 2016, 2:20 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-4823
>     https://issues.apache.org/jira/browse/MESOS-4823
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Frameworks can specify container ports that they want exposed on the
> host's network using this field.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 1232bcda053db3451d18413e81e54e51774f7f22 
>   include/mesos/v1/mesos.proto 1048fae62733926b5e863a0c1629bba69e35e43b 
> 
> Diff: https://reviews.apache.org/r/46035/diff/
> 
> 
> Testing
> -------
> 
> make
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>


Re: Review Request 46035: Introduced `exposed_ports` field in `NetworkInfo`.

Posted by Avinash sridharan <av...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46035/
-----------------------------------------------------------

(Updated April 13, 2016, 2:20 p.m.)


Review request for mesos and Jie Yu.


Changes
-------

Rebased.


Bugs: MESOS-4823
    https://issues.apache.org/jira/browse/MESOS-4823


Repository: mesos


Description
-------

Frameworks can specify container ports that they want exposed on the
host's network using this field.


Diffs (updated)
-----

  include/mesos/mesos.proto 1232bcda053db3451d18413e81e54e51774f7f22 
  include/mesos/v1/mesos.proto 1048fae62733926b5e863a0c1629bba69e35e43b 

Diff: https://reviews.apache.org/r/46035/diff/


Testing
-------

make


Thanks,

Avinash sridharan