You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2021/01/20 06:11:41 UTC
[GitHub] [hudi] teeyog opened a new pull request #2466: [MINOR] Remove redundant judgments
teeyog opened a new pull request #2466:
URL: https://github.com/apache/hudi/pull/2466
## *Tips*
- *Thank you very much for contributing to Apache Hudi.*
- *Please review https://hudi.apache.org/contributing.html before opening a pull request.*
## What is the purpose of the pull request
```long recordsToAppend = Math.min(xxx,totalUnassignedInserts);```
```recordsToAppend``` is greater than 0, ```totalUnassignedInserts``` must be greater than 0
## Brief change log
*(for example:)*
- *Modify AnnotationLocation checkstyle rule in checkstyle.xml*
## Verify this pull request
*(Please pick either of the following options)*
This pull request is a trivial rework / code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
(or)
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end.*
- *Added HoodieClientWriteTest to verify the change.*
- *Manually verified the change by running a job locally.*
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] teeyog commented on pull request #2466: [MINOR] Remove redundant judgments
Posted by GitBox <gi...@apache.org>.
teeyog commented on pull request #2466:
URL: https://github.com/apache/hudi/pull/2466#issuecomment-763412387
> @teeyog This check seems necessary, since it is in a for loop
@wangxianghu Thank you for your review
```recordsToAppend``` is the smaller value of ```totalUnassignedInserts``` and another value, that is ```totalUnassignedInserts>=recordsToAppend```, that is to say ```recordsToAppend>0```, then totalUnassignedInserts must be greater than 0
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] wangxianghu commented on pull request #2466: [MINOR] Remove redundant judgments
Posted by GitBox <gi...@apache.org>.
wangxianghu commented on pull request #2466:
URL: https://github.com/apache/hudi/pull/2466#issuecomment-763429076
> > @teeyog This check seems necessary, since it is in a for loop
>
> @wangxianghu Thank you for your review
> `recordsToAppend` is the smaller value of `totalUnassignedInserts` and another value, that is `totalUnassignedInserts>=recordsToAppend`, that is to say `recordsToAppend>0`, then totalUnassignedInserts must be greater than 0
My bad, you're right
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] garyli1019 merged pull request #2466: [MINOR] Remove redundant judgments
Posted by GitBox <gi...@apache.org>.
garyli1019 merged pull request #2466:
URL: https://github.com/apache/hudi/pull/2466
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] codecov-io commented on pull request #2466: [MINOR] Remove redundant judgments
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #2466:
URL: https://github.com/apache/hudi/pull/2466#issuecomment-763476716
# [Codecov](https://codecov.io/gh/apache/hudi/pull/2466?src=pr&el=h1) Report
> Merging [#2466](https://codecov.io/gh/apache/hudi/pull/2466?src=pr&el=desc) (283a5d5) into [master](https://codecov.io/gh/apache/hudi/commit/5ca0625b277efa3a73d2ae0fbdfa4c6163f312d2?el=desc) (5ca0625) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/hudi/pull/2466?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #2466 +/- ##
========================================
Coverage 9.68% 9.68%
Complexity 48 48
========================================
Files 53 53
Lines 1930 1930
Branches 230 230
========================================
Hits 187 187
Misses 1730 1730
Partials 13 13
```
| Flag | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| hudiutilities | `9.68% <ø> (ø)` | `0.00 <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org