You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/03/16 12:19:05 UTC
[GitHub] [airflow] malthe opened a new pull request #22310: Add generic connection type
malthe opened a new pull request #22310:
URL: https://github.com/apache/airflow/pull/22310
See https://github.com/apache/airflow/discussions/20350.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #22310: Add generic connection type
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #22310:
URL: https://github.com/apache/airflow/pull/22310
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #22310: Add generic connection type
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #22310:
URL: https://github.com/apache/airflow/pull/22310#issuecomment-1069365930
Yeah. I think it's good to have it to avoid confusion from the users. We had the same problem with email connection. This is really to give the right answer to the users who seek for it in the UI and don't realize they could use HTTP for example
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on pull request #22310: Add generic connection type
Posted by GitBox <gi...@apache.org>.
eladkal commented on pull request #22310:
URL: https://github.com/apache/airflow/pull/22310#issuecomment-1069099918
Just to mention that Airflow doesn't enforce `conn_type` - so it doesn't really matter what user will choose.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #22310: Add generic connection type
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #22310:
URL: https://github.com/apache/airflow/pull/22310#issuecomment-1069110933
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] malthe commented on pull request #22310: Add generic connection type
Posted by GitBox <gi...@apache.org>.
malthe commented on pull request #22310:
URL: https://github.com/apache/airflow/pull/22310#issuecomment-1069129783
@eladkal yeah it's just not to add confusion about a connection entry. I'd rather have _Generic_ than AWS (unless of course it really is an AWS connection).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org