You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/08/10 15:52:28 UTC
[GitHub] [airflow] Maor-Shmueli opened a new pull request, #25647: update statsd-exporter mappings
Maor-Shmueli opened a new pull request, #25647:
URL: https://github.com/apache/airflow/pull/25647
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
Updating statsd-exporter `mappings.yml` file
for all current Airflow supported metrics that require mapping - metrics with variable name that can be mapped to Prometheus label (like job/dag/task_id).
> We should use both regex and glob matching types cause glob does not support catching labels that do not divide by dot(.).
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Maor-Shmueli commented on pull request #25647: update statsd-exporter mappings
Posted by GitBox <gi...@apache.org>.
Maor-Shmueli commented on PR #25647:
URL: https://github.com/apache/airflow/pull/25647#issuecomment-1224108659
@dstandish @jedcunningham Just to clarify,
I ran into this file while me and my team set up statsd-exporer for airflow metrics.
I noticed that it wasn't maintained for a while and was not aligned with the current version airflow metrics.
So I did some tidying up, and basically:
- I took all metrics that need a mapping (metrics with variable labels) from the [documentation](https://airflow.apache.org/docs/apache-airflow/stable/logging-monitoring/metrics.html), and created a mapping for each one of them.
- The mappings are by the order of the metrics in docs, and I added the original metric name as a comment before the mapping.
- Some of the labels was not aligned with the labels in docs (like operator → operator_name) so I changed them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #25647: update statsd-exporter mappings
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #25647:
URL: https://github.com/apache/airflow/pull/25647#issuecomment-1221625788
@dstandish @jedcunningham -> WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #25647: update statsd-exporter mappings
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #25647:
URL: https://github.com/apache/airflow/pull/25647#issuecomment-1319380596
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] closed pull request #25647: update statsd-exporter mappings
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #25647: update statsd-exporter mappings
URL: https://github.com/apache/airflow/pull/25647
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #25647: update statsd-exporter mappings
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #25647:
URL: https://github.com/apache/airflow/pull/25647#issuecomment-1229054949
I marked it as candidate to merge for Helm Chart 1.7.0 - pending review and merge by the team :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #25647: update statsd-exporter mappings
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on PR #25647:
URL: https://github.com/apache/airflow/pull/25647#issuecomment-1210902766
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/BREEZE.rst) for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham commented on pull request #25647: update statsd-exporter mappings
Posted by GitBox <gi...@apache.org>.
jedcunningham commented on PR #25647:
URL: https://github.com/apache/airflow/pull/25647#issuecomment-1245632718
Unfortunately, adding mappings like this is a breaking change.
For example, lets look at `dag_processing.last_duration.<dag_file>`. Right now that's `airflow_dag_processing_last_duration_hello_world` but will end up being `airflow_dag_processing_last_duration{dag_file="hello-world"}.
Same thing with the `operator` vs `operator_name` thing - we can't change it for this release.
So unfortunately, until we are ready for 2.0 of the chart we can't make these changes.
I think https://github.com/apache/airflow/pull/25219 is closer to what we need for now as it opens up the possibility for users of the charts to provide their own mappings.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org