You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2020/08/13 07:23:26 UTC

[GitHub] [nifi-minifi-cpp] hunyadi-dev opened a new pull request #871: MINIFICPP-1203 - Remove extra spaces around parentheses according to linter recommendation

hunyadi-dev opened a new pull request #871:
URL: https://github.com/apache/nifi-minifi-cpp/pull/871


   Automatic fixes done using:
   
   ```zsh
   ➜ make linter |& egrep -v '^Done processing|^Ignoring' |& tee errors.txt | less
   ➜ cat errors.txt | grep "Extra space before (" | tr ":" " " | cut -d" " -f1,2 | sort -rn -k1 -k2 | xargs -n 2 sh -c 'sed -i "" "$2s/ (/(/g" $1' sh
   ➜ cat errors.txt | grep "Extra space before )" | tr ":" " " | cut -d" " -f1,2 | sort -rn -k1 -k2 | xargs -n 2 sh -c 'sed -i "" "$2s/ )/)/g" $1' sh
   ➜ cat errors.txt | grep "Extra space after (" | tr ":" " " | cut -d" " -f1,2 | sort -rn -k1 -k2 | xargs -n 2 sh -c 'sed -i "" "$2s/( /(/g" $1' sh
   ➜ cat errors.txt | grep "Extra space after )" | tr ":" " " | cut -d" " -f1,2 | sort -rn -k1 -k2 | xargs -n 2 sh -c 'sed -i "" "$2s/) /)/g" $1' sh
   ➜ cat errors.txt | grep "Mismatching spaces" | tr ":" " " | cut -d" " -f1,2 | sort -rn -k1 -k2 | xargs -n 2 sh -c 'sed -i "" "$2s/( /(/g" $1' sh
   ➜ cat errors.txt | grep "Mismatching spaces" | tr ":" " " | cut -d" " -f1,2 | sort -rn -k1 -k2 | xargs -n 2 sh -c 'sed -i "" "$2s/ )/)/g" $1' sh
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #871: MINIFICPP-1203 - Remove extra spaces around parentheses according to linter recommendation

Posted by GitBox <gi...@apache.org>.
hunyadi-dev commented on a change in pull request #871:
URL: https://github.com/apache/nifi-minifi-cpp/pull/871#discussion_r469969174



##########
File path: main/AgentDocs.cpp
##########
@@ -129,7 +129,7 @@ void AgentDocs::generate(const std::string &docsdir, std::ostream &genStream) {
 
   auto fileFind = [&fileList,this](const std::string& base_path, const std::string& file) -> bool {
     if (file.find(".extra") == std::string::npos)
-      fileList.insert( std::make_pair(file, base_path + utils::file::FileUtils::get_separator() + file) );
+      fileList.insert(std::make_pair(file, base_path + utils::file::FileUtils::get_separator() + file) );

Review comment:
       Corrected.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #871: MINIFICPP-1203 - Remove extra spaces around parentheses according to linter recommendation

Posted by GitBox <gi...@apache.org>.
szaszm commented on a change in pull request #871:
URL: https://github.com/apache/nifi-minifi-cpp/pull/871#discussion_r469841552



##########
File path: extensions/jni/jvm/JVMLoader.h
##########
@@ -349,7 +349,7 @@ class JVMLoader {
     }
 
 #ifdef _MSC_VER
-#pragma warning( suppress: 4054 )

Review comment:
       missed space before closing paren

##########
File path: main/AgentDocs.cpp
##########
@@ -129,7 +129,7 @@ void AgentDocs::generate(const std::string &docsdir, std::ostream &genStream) {
 
   auto fileFind = [&fileList,this](const std::string& base_path, const std::string& file) -> bool {
     if (file.find(".extra") == std::string::npos)
-      fileList.insert( std::make_pair(file, base_path + utils::file::FileUtils::get_separator() + file) );
+      fileList.insert(std::make_pair(file, base_path + utils::file::FileUtils::get_separator() + file) );

Review comment:
       missed space before last closing paren




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #871: MINIFICPP-1203 - Remove extra spaces around parentheses according to linter recommendation

Posted by GitBox <gi...@apache.org>.
hunyadi-dev commented on a change in pull request #871:
URL: https://github.com/apache/nifi-minifi-cpp/pull/871#discussion_r469969075



##########
File path: extensions/jni/jvm/JVMLoader.h
##########
@@ -349,7 +349,7 @@ class JVMLoader {
     }
 
 #ifdef _MSC_VER
-#pragma warning( suppress: 4054 )

Review comment:
       Corrected.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi-minifi-cpp] szaszm closed pull request #871: MINIFICPP-1203 - Remove extra spaces around parentheses according to linter recommendation

Posted by GitBox <gi...@apache.org>.
szaszm closed pull request #871:
URL: https://github.com/apache/nifi-minifi-cpp/pull/871


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org