You are viewing a plain text version of this content. The canonical link for it is here.
Posted to docs@httpd.apache.org by Tony Stevenson <to...@pc-tony.com> on 2007/06/09 02:06:33 UTC

Patch for trunk/howto/cgi.xml

Hi,

See attached a copy of my patch for trunk/howto/cgi.xml
This fix came from  http://issues.apache.org/bugzilla/show_bug.cgi?id=41517

Though the fix, for this issue may have been an obvious one.  Having a 
few lines in the docs just to make sure that the module is loaded is not 
so bad.
Seeing as further down in the "But it's still not working!" section it 
refers you back to the top of the page to check your configuration.


Cheers,
Tony



Re: Patch for trunk/howto/cgi.xml

Posted by Tony Stevenson <to...@pc-tony.com>.

Jason Lingohr wrote:
> Tony Stevenson wrote:
>   
>> The patch is for trunk.  Hence the subject line  :)
>> Good point on the path to the file though which is why I include it in
>> the email.  As getting Tortoise to add the path is not pretty.
>> You basically have to tell it to generate patches for the entire tree,
>> then de-select the ones you don't want to patch, in this case all
>> files, except  cgi.xml, and that takes a *very long* time
>>
>> Updated patch attached.
>>
>>     
> Committed, with some modifications.  Thanks :)
>   

Cheers.
> (And perhaps get a better SVN environment ;))
>   

Hmm..  :)

>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: docs-unsubscribe@httpd.apache.org
> For additional commands, e-mail: docs-help@httpd.apache.org
>
>   

---------------------------------------------------------------------
To unsubscribe, e-mail: docs-unsubscribe@httpd.apache.org
For additional commands, e-mail: docs-help@httpd.apache.org


Re: Patch for trunk/howto/cgi.xml

Posted by Jason Lingohr <ja...@lucid.net.au>.
Tony Stevenson wrote:
> The patch is for trunk.  Hence the subject line  :)
> Good point on the path to the file though which is why I include it in
> the email.  As getting Tortoise to add the path is not pretty.
> You basically have to tell it to generate patches for the entire tree,
> then de-select the ones you don't want to patch, in this case all
> files, except  cgi.xml, and that takes a *very long* time
>
> Updated patch attached.
>
Committed, with some modifications.  Thanks :)

(And perhaps get a better SVN environment ;))


---------------------------------------------------------------------
To unsubscribe, e-mail: docs-unsubscribe@httpd.apache.org
For additional commands, e-mail: docs-help@httpd.apache.org


Re: Patch for trunk/howto/cgi.xml

Posted by Tony Stevenson <to...@pc-tony.com>.

Vincent Bray wrote:
> On 09/06/07, Tony Stevenson <to...@pc-tony.com> wrote:
>> Index: cgi.xml
>> ===================================================================
>> --- cgi.xml     (revision 545660)
>> +++ cgi.xml     (working copy)
>> @@ -57,6 +57,15 @@
>>      need to have Apache configured to permit CGI execution. There
>>      are several ways to do this.</p>
>>
>> +    <p>If Apache has been build with shared module support you need to
>> +    ensure that the module is loaded, in your <code>httpd.conf</code>
>> +    you need to make sure the <code>LoadModule</code> directive has not
>> +    been commented out.  A correctly configured directive may look 
>> like this:</p>
>
> s/build/built/
>
> Your phrasing seems a little awkward but I'm not sure which page this
> is for as your diff doesn't specify the path. Could I suggest that you
> send patches from the base of the httpd directory, and specify which
> version the patch is for? I believe it's generally best to send
> patches for trunk by default.

The patch is for trunk.  Hence the subject line  :)
Good point on the path to the file though which is why I include it in 
the email.  As getting Tortoise to add the path is not pretty.
You basically have to tell it to generate patches for the entire tree, 
then de-select the ones you don't want to patch, in this case all files, 
except  cgi.xml, and that takes a *very long* time

Updated patch attached.




Re: Patch for trunk/howto/cgi.xml

Posted by Vincent Bray <no...@gmail.com>.
On 09/06/07, Tony Stevenson <to...@pc-tony.com> wrote:
> Index: cgi.xml
> ===================================================================
> --- cgi.xml     (revision 545660)
> +++ cgi.xml     (working copy)
> @@ -57,6 +57,15 @@
>      need to have Apache configured to permit CGI execution. There
>      are several ways to do this.</p>
>
> +    <p>If Apache has been build with shared module support you need to
> +    ensure that the module is loaded, in your <code>httpd.conf</code>
> +    you need to make sure the <code>LoadModule</code> directive has not
> +    been commented out.  A correctly configured directive may look like this:</p>

s/build/built/

Your phrasing seems a little awkward but I'm not sure which page this
is for as your diff doesn't specify the path. Could I suggest that you
send patches from the base of the httpd directory, and specify which
version the patch is for? I believe it's generally best to send
patches for trunk by default.

-- 
noodl

---------------------------------------------------------------------
To unsubscribe, e-mail: docs-unsubscribe@httpd.apache.org
For additional commands, e-mail: docs-help@httpd.apache.org