You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/02/14 19:01:58 UTC

[GitHub] [hudi] xushiyan commented on pull request #4795: [HUDI-1576] Make archiving an async service

xushiyan commented on pull request #4795:
URL: https://github.com/apache/hudi/pull/4795#issuecomment-1039443472


   > Do you think we need to add any explicit tests for async archiver?
   
   @nsivabalan i don't think there is anything special about archiver for testing. The only logic is about calling `writeClient.archive()` from the async thread, which is covered by this test case `startServiceShouldInvokeCallArchiveMethod`. Other logic in the async service is almost the same as `AsyncCleanerService`. So i think this part is good.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org