[GitHub] [spark] cloud-fan commented on a change in pull request #35951: [WIP][SPARK-37568][SQL] Support 2-arguments by the convert_timezone() function

[GitBox <gi...@apache.org>]

cloud-fan commented on a change in pull request #35951:
URL: https://github.com/apache/spark/pull/35951#discussion_r833289239



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
##########
@@ -3002,14 +3002,17 @@ object SubtractDates {
   usage = "_FUNC_(sourceTz, targetTz, sourceTs) - Converts the timestamp without time zone `sourceTs` from the `sourceTz` time zone to `targetTz`. ",
   arguments = """
     Arguments:
-      * sourceTz - the time zone for the input timestamp
+      * sourceTz - the time zone for the input timestamp.
+                   If it is missed, the current session time zone is used as the source time zone.

Review comment:
       We don't have by-name parameters in SQL functions yet, and it's weird that the non-last parameter can be optional...




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org