[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #3934: support abs, ceil, exp, floor, ln, log, sqrt math transform function

[GitBox <gi...@apache.org>]

Jackie-Jiang commented on a change in pull request #3934: support abs,ceil,exp,floor,ln,log,sqrt math transform function
URL: https://github.com/apache/incubator-pinot/pull/3934#discussion_r290988482
 
 

 ##########
 File path: pinot-core/src/test/java/org/apache/pinot/core/operator/transform/function/BaseTransformFunctionTest.java
 ##########
 @@ -65,6 +65,7 @@
   protected static final String STRING_SV_COLUMN = "stringSV";
   protected static final String INT_MV_COLUMN = "intMV";
   protected static final String TIME_COLUMN = "time";
+  protected static final String DOUBLE2_SV_COLUMN = "double2SV";
 
 Review comment:
   Please reuse the DOUBLE_SV_COLUMN, while you can change its value (line 92) if you need value larger than 1 for tests.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org