[GitHub] [sling-org-apache-sling-feature-cpconverter] niekraaijmakers commented on a diff in pull request #158: [Shelved] Sling 11777 2 - improve segmentprocessing

["niekraaijmakers (via GitHub)" <gi...@apache.org>]

niekraaijmakers commented on code in PR #158:
URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/158#discussion_r1112737327


##########
src/main/java/org/apache/sling/feature/cpconverter/ContentPackage2FeatureModelConverter.java:
##########
@@ -286,11 +295,9 @@ public void convert(@NotNull File... contentPackages) throws IOException, Conver
             // analyze sub-content packages in order to filter out
             // possible outdated conflicting packages
             recollectorVaultPackageScanner.traverse(pack);
-
             logger.info("content-package '{}' successfully read!", contentPackage);
 
             aclManager.reset();
-            bundleSlingInitialContentExtractor.reset();

Review Comment:
   Basically it didn't do anything in the past ... it was added because acl manager etc did reset something.. the paths were cleared but empty to begin with :( 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org