[GitHub] [spark] zhengruifeng commented on a diff in pull request #36977: [SPARK-39579][SQL][PYTHON] Make ListFunctions/getFunction/functionExists compatible with 3 layer namespace

[GitBox <gi...@apache.org>]

zhengruifeng commented on code in PR #36977:
URL: https://github.com/apache/spark/pull/36977#discussion_r911013941


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala:
##########
@@ -2139,16 +2139,16 @@ class Analyzer(override val catalogManager: CatalogManager)
     }
 
     def lookupBuiltinOrTempFunction(name: Seq[String]): Option[ExpressionInfo] = {
-      if (name.length == 1) {
-        v1SessionCatalog.lookupBuiltinOrTempFunction(name.head)
+      if (name.length == 1 || name.length == 3) {

Review Comment:
   to support look up temp function with a 3-layer ident.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org