You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Eli Collins (JIRA)" <ji...@apache.org> on 2012/08/23 01:02:41 UTC
[jira] [Created] (HADOOP-8722) Update BUILDING.txt to indicate
snappy.lib is required
Eli Collins created HADOOP-8722:
-----------------------------------
Summary: Update BUILDING.txt to indicate snappy.lib is required
Key: HADOOP-8722
URL: https://issues.apache.org/jira/browse/HADOOP-8722
Project: Hadoop Common
Issue Type: Improvement
Components: documentation
Reporter: Eli Collins
Priority: Minor
HADOOP-8620 changed the default of snappy.lib from snappy.prefix/lib to the empty which means we need to update the following in BUILDING.txt to indicate it needs to be set (or restore the default to snappy.prefix/lib).
{noformat}
* Use -Dsnappy.prefix=(/usr/local) & -Dbundle.snappy=(false) to compile
{noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8722) -Dbundle.snappy doesn't work unless
-Dsnappy.lib is set
Posted by "Colin Patrick McCabe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Colin Patrick McCabe updated HADOOP-8722:
-----------------------------------------
Target Version/s: 2.2.0-alpha
Affects Version/s: 2.2.0-alpha
Assignee: Colin Patrick McCabe
> -Dbundle.snappy doesn't work unless -Dsnappy.lib is set
> -------------------------------------------------------
>
> Key: HADOOP-8722
> URL: https://issues.apache.org/jira/browse/HADOOP-8722
> Project: Hadoop Common
> Issue Type: Bug
> Components: documentation
> Affects Versions: 2.2.0-alpha
> Reporter: Eli Collins
> Assignee: Colin Patrick McCabe
> Priority: Minor
> Attachments: HADOOP-8722.002.patch
>
>
> HADOOP-8620 changed the default of snappy.lib from snappy.prefix/lib to empty. This, in turn, means that you can't use {{-Dbundle.snappy}} without setting {{-Dsnappy.lib}}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8722) Update BUILDING.txt with latest
snappy info
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eli Collins updated HADOOP-8722:
--------------------------------
Summary: Update BUILDING.txt with latest snappy info (was: -Dbundle.snappy doesn't work unless -Dsnappy.lib is set)
> Update BUILDING.txt with latest snappy info
> -------------------------------------------
>
> Key: HADOOP-8722
> URL: https://issues.apache.org/jira/browse/HADOOP-8722
> Project: Hadoop Common
> Issue Type: Bug
> Components: documentation
> Affects Versions: 2.2.0-alpha
> Reporter: Eli Collins
> Assignee: Colin Patrick McCabe
> Priority: Minor
> Attachments: HADOOP-8722.002.patch, HADOOP-8722.003.patch, HADOOP-8722.004.patch, hadoop-8722.txt
>
>
> HADOOP-8620 changed the default of snappy.lib from snappy.prefix/lib to empty. This, in turn, means that you can't use {{-Dbundle.snappy}} without setting {{-Dsnappy.lib}}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8722) -Dbundle.snappy doesn't work
unless -Dsnappy.lib is set
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13439969#comment-13439969 ]
Eli Collins commented on HADOOP-8722:
-------------------------------------
Maybe just update BUILDING.txt to indicate snappy.lib is required? Seems like with this patch we could end up copying two snappy lib files and think it's fine to just doc the required dirs.
> -Dbundle.snappy doesn't work unless -Dsnappy.lib is set
> -------------------------------------------------------
>
> Key: HADOOP-8722
> URL: https://issues.apache.org/jira/browse/HADOOP-8722
> Project: Hadoop Common
> Issue Type: Bug
> Components: documentation
> Affects Versions: 2.2.0-alpha
> Reporter: Eli Collins
> Assignee: Colin Patrick McCabe
> Priority: Minor
> Attachments: HADOOP-8722.002.patch
>
>
> HADOOP-8620 changed the default of snappy.lib from snappy.prefix/lib to empty. This, in turn, means that you can't use {{-Dbundle.snappy}} without setting {{-Dsnappy.lib}}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8722) -Dbundle.snappy doesn't work unless
-Dsnappy.lib is set
Posted by "Colin Patrick McCabe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Colin Patrick McCabe updated HADOOP-8722:
-----------------------------------------
Attachment: HADOOP-8722.004.patch
> -Dbundle.snappy doesn't work unless -Dsnappy.lib is set
> -------------------------------------------------------
>
> Key: HADOOP-8722
> URL: https://issues.apache.org/jira/browse/HADOOP-8722
> Project: Hadoop Common
> Issue Type: Bug
> Components: documentation
> Affects Versions: 2.2.0-alpha
> Reporter: Eli Collins
> Assignee: Colin Patrick McCabe
> Priority: Minor
> Attachments: HADOOP-8722.002.patch, HADOOP-8722.003.patch, HADOOP-8722.004.patch
>
>
> HADOOP-8620 changed the default of snappy.lib from snappy.prefix/lib to empty. This, in turn, means that you can't use {{-Dbundle.snappy}} without setting {{-Dsnappy.lib}}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8722) -Dbundle.snappy doesn't work unless
-Dsnappy.lib is set
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eli Collins updated HADOOP-8722:
--------------------------------
Status: Open (was: Patch Available)
> -Dbundle.snappy doesn't work unless -Dsnappy.lib is set
> -------------------------------------------------------
>
> Key: HADOOP-8722
> URL: https://issues.apache.org/jira/browse/HADOOP-8722
> Project: Hadoop Common
> Issue Type: Bug
> Components: documentation
> Affects Versions: 2.2.0-alpha
> Reporter: Eli Collins
> Assignee: Colin Patrick McCabe
> Priority: Minor
> Attachments: HADOOP-8722.002.patch, HADOOP-8722.003.patch
>
>
> HADOOP-8620 changed the default of snappy.lib from snappy.prefix/lib to empty. This, in turn, means that you can't use {{-Dbundle.snappy}} without setting {{-Dsnappy.lib}}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8722) Update BUILDING.txt with latest
snappy info
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13445950#comment-13445950 ]
Hudson commented on HADOOP-8722:
--------------------------------
Integrated in Hadoop-Mapreduce-trunk #1182 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1182/])
HADOOP-8722. Update BUILDING.txt with latest snappy info. Contributed by Colin Patrick McCabe (Revision 1379280)
Result = SUCCESS
eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1379280
Files :
* /hadoop/common/trunk/BUILDING.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
> Update BUILDING.txt with latest snappy info
> -------------------------------------------
>
> Key: HADOOP-8722
> URL: https://issues.apache.org/jira/browse/HADOOP-8722
> Project: Hadoop Common
> Issue Type: Bug
> Components: documentation
> Affects Versions: 2.2.0-alpha
> Reporter: Eli Collins
> Assignee: Colin Patrick McCabe
> Priority: Minor
> Fix For: 2.2.0-alpha
>
> Attachments: HADOOP-8722.002.patch, HADOOP-8722.003.patch, HADOOP-8722.004.patch, hadoop-8722.txt
>
>
> HADOOP-8620 changed the default of snappy.lib from snappy.prefix/lib to empty. This, in turn, means that you can't use {{-Dbundle.snappy}} without setting {{-Dsnappy.lib}}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8722) -Dbundle.snappy doesn't work
unless -Dsnappy.lib is set
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13445474#comment-13445474 ]
Eli Collins commented on HADOOP-8722:
-------------------------------------
Looks good, minor nits:
- "-Dsnappy.prefix or -Dsnappy.lib" should be "and"
- "if Snappy is missing" should be "and snappy is not installed on your host"
- "Most of the time, these options should not be necessary" should be something like "These options are not required if the snappy libraries and headers are installed in the system lib and includes directories."
> -Dbundle.snappy doesn't work unless -Dsnappy.lib is set
> -------------------------------------------------------
>
> Key: HADOOP-8722
> URL: https://issues.apache.org/jira/browse/HADOOP-8722
> Project: Hadoop Common
> Issue Type: Bug
> Components: documentation
> Affects Versions: 2.2.0-alpha
> Reporter: Eli Collins
> Assignee: Colin Patrick McCabe
> Priority: Minor
> Attachments: HADOOP-8722.002.patch, HADOOP-8722.003.patch
>
>
> HADOOP-8620 changed the default of snappy.lib from snappy.prefix/lib to empty. This, in turn, means that you can't use {{-Dbundle.snappy}} without setting {{-Dsnappy.lib}}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8722) -Dbundle.snappy doesn't work
unless -Dsnappy.lib is set
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13440143#comment-13440143 ]
Hadoop QA commented on HADOOP-8722:
-----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12542061/HADOOP-8722.002.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+0 tests included. The patch appears to be a documentation patch that doesn't require tests.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed unit tests in .
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1349//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1349//console
This message is automatically generated.
> -Dbundle.snappy doesn't work unless -Dsnappy.lib is set
> -------------------------------------------------------
>
> Key: HADOOP-8722
> URL: https://issues.apache.org/jira/browse/HADOOP-8722
> Project: Hadoop Common
> Issue Type: Bug
> Components: documentation
> Affects Versions: 2.2.0-alpha
> Reporter: Eli Collins
> Assignee: Colin Patrick McCabe
> Priority: Minor
> Attachments: HADOOP-8722.002.patch
>
>
> HADOOP-8620 changed the default of snappy.lib from snappy.prefix/lib to empty. This, in turn, means that you can't use {{-Dbundle.snappy}} without setting {{-Dsnappy.lib}}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8722) -Dbundle.snappy doesn't work unless
-Dsnappy.lib is set
Posted by "Colin Patrick McCabe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Colin Patrick McCabe updated HADOOP-8722:
-----------------------------------------
Status: Patch Available (was: Open)
> -Dbundle.snappy doesn't work unless -Dsnappy.lib is set
> -------------------------------------------------------
>
> Key: HADOOP-8722
> URL: https://issues.apache.org/jira/browse/HADOOP-8722
> Project: Hadoop Common
> Issue Type: Bug
> Components: documentation
> Reporter: Eli Collins
> Priority: Minor
> Attachments: HADOOP-8722.002.patch
>
>
> HADOOP-8620 changed the default of snappy.lib from snappy.prefix/lib to empty. This, in turn, means that you can't use {{-Dbundle.snappy}} without setting {{-Dsnappy.lib}}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8722) -Dbundle.snappy doesn't work
unless -Dsnappy.lib is set
Posted by "Colin Patrick McCabe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13445518#comment-13445518 ]
Colin Patrick McCabe commented on HADOOP-8722:
----------------------------------------------
I reworded this a bit. Thinking about it, I realized the snappy options might look better in a single section. Also there should be some intro text about what the heck snappy is before launching into these details.
bq. "-Dsnappy.prefix or -Dsnappy.lib" should be "and"
Seemed better to give each option its own section, I got rid of the 'or' completely...
bq. "Most of the time, these options should not be necessary" should be something like "These options are not required if the snappy libraries and headers are installed in the system lib and includes directories."
I replaced this with "You do not need this option if you have installed snappy through... a package manager"
> -Dbundle.snappy doesn't work unless -Dsnappy.lib is set
> -------------------------------------------------------
>
> Key: HADOOP-8722
> URL: https://issues.apache.org/jira/browse/HADOOP-8722
> Project: Hadoop Common
> Issue Type: Bug
> Components: documentation
> Affects Versions: 2.2.0-alpha
> Reporter: Eli Collins
> Assignee: Colin Patrick McCabe
> Priority: Minor
> Attachments: HADOOP-8722.002.patch, HADOOP-8722.003.patch, HADOOP-8722.004.patch
>
>
> HADOOP-8620 changed the default of snappy.lib from snappy.prefix/lib to empty. This, in turn, means that you can't use {{-Dbundle.snappy}} without setting {{-Dsnappy.lib}}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8722) -Dbundle.snappy doesn't work unless
-Dsnappy.lib is set
Posted by "Colin Patrick McCabe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Colin Patrick McCabe updated HADOOP-8722:
-----------------------------------------
Attachment: (was: HADOOP-8722.003.patch)
> -Dbundle.snappy doesn't work unless -Dsnappy.lib is set
> -------------------------------------------------------
>
> Key: HADOOP-8722
> URL: https://issues.apache.org/jira/browse/HADOOP-8722
> Project: Hadoop Common
> Issue Type: Bug
> Components: documentation
> Affects Versions: 2.2.0-alpha
> Reporter: Eli Collins
> Assignee: Colin Patrick McCabe
> Priority: Minor
> Attachments: HADOOP-8722.002.patch, HADOOP-8722.003.patch
>
>
> HADOOP-8620 changed the default of snappy.lib from snappy.prefix/lib to empty. This, in turn, means that you can't use {{-Dbundle.snappy}} without setting {{-Dsnappy.lib}}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (HADOOP-8722) Update BUILDING.txt with latest
snappy info
Posted by "Arun C Murthy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Arun C Murthy closed HADOOP-8722.
---------------------------------
> Update BUILDING.txt with latest snappy info
> -------------------------------------------
>
> Key: HADOOP-8722
> URL: https://issues.apache.org/jira/browse/HADOOP-8722
> Project: Hadoop Common
> Issue Type: Bug
> Components: documentation
> Affects Versions: 2.0.2-alpha
> Reporter: Eli Collins
> Assignee: Colin Patrick McCabe
> Priority: Minor
> Fix For: 2.0.2-alpha
>
> Attachments: HADOOP-8722.002.patch, HADOOP-8722.003.patch, HADOOP-8722.004.patch, hadoop-8722.txt
>
>
> HADOOP-8620 changed the default of snappy.lib from snappy.prefix/lib to empty. This, in turn, means that you can't use {{-Dbundle.snappy}} without setting {{-Dsnappy.lib}}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (HADOOP-8722) Update BUILDING.txt with latest
snappy info
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eli Collins resolved HADOOP-8722.
---------------------------------
Resolution: Fixed
Fix Version/s: 2.2.0-alpha
Target Version/s: (was: 2.2.0-alpha)
Hadoop Flags: Reviewed
I've committed this, thanks Colin!
> Update BUILDING.txt with latest snappy info
> -------------------------------------------
>
> Key: HADOOP-8722
> URL: https://issues.apache.org/jira/browse/HADOOP-8722
> Project: Hadoop Common
> Issue Type: Bug
> Components: documentation
> Affects Versions: 2.2.0-alpha
> Reporter: Eli Collins
> Assignee: Colin Patrick McCabe
> Priority: Minor
> Fix For: 2.2.0-alpha
>
> Attachments: HADOOP-8722.002.patch, HADOOP-8722.003.patch, HADOOP-8722.004.patch, hadoop-8722.txt
>
>
> HADOOP-8620 changed the default of snappy.lib from snappy.prefix/lib to empty. This, in turn, means that you can't use {{-Dbundle.snappy}} without setting {{-Dsnappy.lib}}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8722) -Dbundle.snappy doesn't work unless
-Dsnappy.lib is set
Posted by "Colin Patrick McCabe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Colin Patrick McCabe updated HADOOP-8722:
-----------------------------------------
Attachment: HADOOP-8722.003.patch
slightly improved version
> -Dbundle.snappy doesn't work unless -Dsnappy.lib is set
> -------------------------------------------------------
>
> Key: HADOOP-8722
> URL: https://issues.apache.org/jira/browse/HADOOP-8722
> Project: Hadoop Common
> Issue Type: Bug
> Components: documentation
> Affects Versions: 2.2.0-alpha
> Reporter: Eli Collins
> Assignee: Colin Patrick McCabe
> Priority: Minor
> Attachments: HADOOP-8722.002.patch, HADOOP-8722.003.patch
>
>
> HADOOP-8620 changed the default of snappy.lib from snappy.prefix/lib to empty. This, in turn, means that you can't use {{-Dbundle.snappy}} without setting {{-Dsnappy.lib}}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8722) -Dbundle.snappy doesn't work unless
-Dsnappy.lib is set
Posted by "Colin Patrick McCabe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Colin Patrick McCabe updated HADOOP-8722:
-----------------------------------------
Attachment: HADOOP-8722.002.patch
> -Dbundle.snappy doesn't work unless -Dsnappy.lib is set
> -------------------------------------------------------
>
> Key: HADOOP-8722
> URL: https://issues.apache.org/jira/browse/HADOOP-8722
> Project: Hadoop Common
> Issue Type: Bug
> Components: documentation
> Affects Versions: 2.2.0-alpha
> Reporter: Eli Collins
> Priority: Minor
> Attachments: HADOOP-8722.002.patch
>
>
> HADOOP-8620 changed the default of snappy.lib from snappy.prefix/lib to empty. This, in turn, means that you can't use {{-Dbundle.snappy}} without setting {{-Dsnappy.lib}}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8722) -Dbundle.snappy doesn't work unless
-Dsnappy.lib is set
Posted by "Colin Patrick McCabe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Colin Patrick McCabe updated HADOOP-8722:
-----------------------------------------
Attachment: HADOOP-8722.003.patch
After thinking about it, I think I agree with Eli's suggestion here. Let's just update the docs. It's the easiest option for everyone.
The docs need to be updated anyway because they're missing a few of the newer options.
> -Dbundle.snappy doesn't work unless -Dsnappy.lib is set
> -------------------------------------------------------
>
> Key: HADOOP-8722
> URL: https://issues.apache.org/jira/browse/HADOOP-8722
> Project: Hadoop Common
> Issue Type: Bug
> Components: documentation
> Affects Versions: 2.2.0-alpha
> Reporter: Eli Collins
> Assignee: Colin Patrick McCabe
> Priority: Minor
> Attachments: HADOOP-8722.002.patch, HADOOP-8722.003.patch
>
>
> HADOOP-8620 changed the default of snappy.lib from snappy.prefix/lib to empty. This, in turn, means that you can't use {{-Dbundle.snappy}} without setting {{-Dsnappy.lib}}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8722) -Dbundle.snappy doesn't work unless
-Dsnappy.lib is set
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eli Collins updated HADOOP-8722:
--------------------------------
Attachment: hadoop-8722.txt
+1 looks great. Attaching a slight updated version with some small tweaks.
> -Dbundle.snappy doesn't work unless -Dsnappy.lib is set
> -------------------------------------------------------
>
> Key: HADOOP-8722
> URL: https://issues.apache.org/jira/browse/HADOOP-8722
> Project: Hadoop Common
> Issue Type: Bug
> Components: documentation
> Affects Versions: 2.2.0-alpha
> Reporter: Eli Collins
> Assignee: Colin Patrick McCabe
> Priority: Minor
> Attachments: HADOOP-8722.002.patch, HADOOP-8722.003.patch, HADOOP-8722.004.patch, hadoop-8722.txt
>
>
> HADOOP-8620 changed the default of snappy.lib from snappy.prefix/lib to empty. This, in turn, means that you can't use {{-Dbundle.snappy}} without setting {{-Dsnappy.lib}}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8722) -Dbundle.snappy doesn't work unless
-Dsnappy.lib is set
Posted by "Colin Patrick McCabe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Colin Patrick McCabe updated HADOOP-8722:
-----------------------------------------
Description: HADOOP-8620 changed the default of snappy.lib from snappy.prefix/lib to empty. This, in turn, means that you can't use {{-Dbundle.snappy}} without setting {{-Dsnappy.lib}} (was: HADOOP-8620 changed the default of snappy.lib from snappy.prefix/lib to the empty which means we need to update the following in BUILDING.txt to indicate it needs to be set (or restore the default to snappy.prefix/lib).
{noformat}
* Use -Dsnappy.prefix=(/usr/local) & -Dbundle.snappy=(false) to compile
{noformat}
)
Issue Type: Bug (was: Improvement)
Summary: -Dbundle.snappy doesn't work unless -Dsnappy.lib is set (was: Update BUILDING.txt to indicate snappy.lib is required)
> -Dbundle.snappy doesn't work unless -Dsnappy.lib is set
> -------------------------------------------------------
>
> Key: HADOOP-8722
> URL: https://issues.apache.org/jira/browse/HADOOP-8722
> Project: Hadoop Common
> Issue Type: Bug
> Components: documentation
> Reporter: Eli Collins
> Priority: Minor
>
> HADOOP-8620 changed the default of snappy.lib from snappy.prefix/lib to empty. This, in turn, means that you can't use {{-Dbundle.snappy}} without setting {{-Dsnappy.lib}}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8722) Update BUILDING.txt with latest
snappy info
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13445895#comment-13445895 ]
Hudson commented on HADOOP-8722:
--------------------------------
Integrated in Hadoop-Hdfs-trunk #1151 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1151/])
HADOOP-8722. Update BUILDING.txt with latest snappy info. Contributed by Colin Patrick McCabe (Revision 1379280)
Result = FAILURE
eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1379280
Files :
* /hadoop/common/trunk/BUILDING.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
> Update BUILDING.txt with latest snappy info
> -------------------------------------------
>
> Key: HADOOP-8722
> URL: https://issues.apache.org/jira/browse/HADOOP-8722
> Project: Hadoop Common
> Issue Type: Bug
> Components: documentation
> Affects Versions: 2.2.0-alpha
> Reporter: Eli Collins
> Assignee: Colin Patrick McCabe
> Priority: Minor
> Fix For: 2.2.0-alpha
>
> Attachments: HADOOP-8722.002.patch, HADOOP-8722.003.patch, HADOOP-8722.004.patch, hadoop-8722.txt
>
>
> HADOOP-8620 changed the default of snappy.lib from snappy.prefix/lib to empty. This, in turn, means that you can't use {{-Dbundle.snappy}} without setting {{-Dsnappy.lib}}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8722) -Dbundle.snappy doesn't work
unless -Dsnappy.lib is set
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13444428#comment-13444428 ]
Hadoop QA commented on HADOOP-8722:
-----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12542988/HADOOP-8722.003.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+0 tests included. The patch appears to be a documentation patch that doesn't require tests.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed unit tests in .
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1383//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1383//console
This message is automatically generated.
> -Dbundle.snappy doesn't work unless -Dsnappy.lib is set
> -------------------------------------------------------
>
> Key: HADOOP-8722
> URL: https://issues.apache.org/jira/browse/HADOOP-8722
> Project: Hadoop Common
> Issue Type: Bug
> Components: documentation
> Affects Versions: 2.2.0-alpha
> Reporter: Eli Collins
> Assignee: Colin Patrick McCabe
> Priority: Minor
> Attachments: HADOOP-8722.002.patch, HADOOP-8722.003.patch
>
>
> HADOOP-8620 changed the default of snappy.lib from snappy.prefix/lib to empty. This, in turn, means that you can't use {{-Dbundle.snappy}} without setting {{-Dsnappy.lib}}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8722) -Dbundle.snappy doesn't work
unless -Dsnappy.lib is set
Posted by "Colin Patrick McCabe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13440096#comment-13440096 ]
Colin Patrick McCabe commented on HADOOP-8722:
----------------------------------------------
Looking at our code again, I think it requires the library to be dynamic, so I can just skip the {{.a}} stuff. We use {{dlopen}}, and I don't think that works with {{.a}} (static) libraries.
At that point, there no danger of making two copies of the {{.so}} file, since the second copy would overwrite the first. If the developer puts two different copies of libsnappy.so in {{$\{snappy.lib\}}} or {{$\{snappy.prefix\}}}, I think we can safely discount that as user error.
> -Dbundle.snappy doesn't work unless -Dsnappy.lib is set
> -------------------------------------------------------
>
> Key: HADOOP-8722
> URL: https://issues.apache.org/jira/browse/HADOOP-8722
> Project: Hadoop Common
> Issue Type: Bug
> Components: documentation
> Affects Versions: 2.2.0-alpha
> Reporter: Eli Collins
> Assignee: Colin Patrick McCabe
> Priority: Minor
> Attachments: HADOOP-8722.002.patch
>
>
> HADOOP-8620 changed the default of snappy.lib from snappy.prefix/lib to empty. This, in turn, means that you can't use {{-Dbundle.snappy}} without setting {{-Dsnappy.lib}}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira