You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2017/08/11 19:47:37 UTC
Re: Review Request 60525: Fixed the default filter used by the
allocator.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60525/#review182730
-----------------------------------------------------------
include/mesos/mesos.proto
Line 2257 (original), 2258-2262 (patched)
<https://reviews.apache.org/r/60525/#comment258724>
Is there a suitable place in the documentation for us to mention this?
Also, could you add an update for the changelog which calls out this change?
src/master/allocator/mesos/hierarchical.cpp
Line 1019 (original), 1019 (patched)
<https://reviews.apache.org/r/60525/#comment258727>
s/timeout = timeout =/timeout =/
src/master/allocator/mesos/hierarchical.cpp
Lines 1022 (patched)
<https://reviews.apache.org/r/60525/#comment258728>
s/filters.get()./filters->/
here and elsewhere
src/master/allocator/mesos/hierarchical.cpp
Line 1021 (original), 1026 (patched)
<https://reviews.apache.org/r/60525/#comment258733>
Can you just do
```
timeout = Days(365);
```
src/master/allocator/mesos/hierarchical.cpp
Line 1170 (original), 1180 (patched)
<https://reviews.apache.org/r/60525/#comment258737>
Ditto
src/master/allocator/mesos/hierarchical.cpp
Lines 1187 (patched)
<https://reviews.apache.org/r/60525/#comment258738>
Ditto
src/master/allocator/mesos/hierarchical.cpp
Lines 1190 (patched)
<https://reviews.apache.org/r/60525/#comment258740>
Could you make this language consistent here and below? This line uses "refused resources offer filter", while the next one uses "refused resources filter".
- Greg Mann
On July 26, 2017, 11:30 p.m., Gastón Kleiman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60525/
> -----------------------------------------------------------
>
> (Updated July 26, 2017, 11:30 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Benjamin Mahler, Greg Mann, and Vinod Kone.
>
>
> Bugs: MESOS-7660
> https://issues.apache.org/jira/browse/MESOS-7660
>
>
> Repository: mesos
>
>
> Description
> -------
>
> If a framework accepts/refuses an offer using a very long filter, the
> `HierarchicalAllocator` will use the default filter instead. Meaning
> that it will filter the resources for only 5 seconds. This can happen
> when a framework sets `Filter::refuse_seconds` to a number of seconds
> larger than what fits in `Duration`.
>
> This patch makes the hierarchical allocator cap the filter duration to
> at most 365 days.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto f31f5bdc2ace2b261885b252e7c01ceb9b76c461
> include/mesos/v1/mesos.proto 66386a84bc21989d1c1237e629d5d04662a368fa
> src/master/allocator/mesos/hierarchical.cpp f021c34ef11aac42026ba39c5a1b775794982035
>
>
> Diff: https://reviews.apache.org/r/60525/diff/6/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Gastón Kleiman
>
>
Re: Review Request 60525: Fixed the default filter used by the
allocator.
Posted by Gastón Kleiman <ga...@mesosphere.io>.
> On Aug. 11, 2017, 7:47 p.m., Greg Mann wrote:
> > include/mesos/mesos.proto
> > Line 2257 (original), 2258-2262 (patched)
> > <https://reviews.apache.org/r/60525/diff/6/?file=1787910#file1787910line2258>
> >
> > Is there a suitable place in the documentation for us to mention this?
> >
> > Also, could you add an update for the changelog which calls out this change?
I added something to `docs/scheduler-http-api.md`, most other places that mention Filters tell users to look at the protos.
> On Aug. 11, 2017, 7:47 p.m., Greg Mann wrote:
> > src/master/allocator/mesos/hierarchical.cpp
> > Line 1019 (original), 1019 (patched)
> > <https://reviews.apache.org/r/60525/diff/6/?file=1787912#file1787912line1019>
> >
> > s/timeout = timeout =/timeout =/
:scream: ;-)
> On Aug. 11, 2017, 7:47 p.m., Greg Mann wrote:
> > src/master/allocator/mesos/hierarchical.cpp
> > Line 1170 (original), 1180 (patched)
> > <https://reviews.apache.org/r/60525/diff/6/?file=1787912#file1787912line1180>
> >
> > Ditto
Ohhh no, not again!
- Gastón
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60525/#review182730
-----------------------------------------------------------
On Aug. 12, 2017, 1:07 a.m., Gastón Kleiman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60525/
> -----------------------------------------------------------
>
> (Updated Aug. 12, 2017, 1:07 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Benjamin Mahler, Greg Mann, and Vinod Kone.
>
>
> Bugs: MESOS-7660
> https://issues.apache.org/jira/browse/MESOS-7660
>
>
> Repository: mesos
>
>
> Description
> -------
>
> If a framework accepts/refuses an offer using a very long filter, the
> `HierarchicalAllocator` will use the default filter instead. Meaning
> that it will filter the resources for only 5 seconds. This can happen
> when a framework sets `Filter::refuse_seconds` to a number of seconds
> larger than what fits in `Duration`.
>
> This patch makes the hierarchical allocator cap the filter duration to
> at most 365 days.
>
>
> Diffs
> -----
>
> docs/scheduler-http-api.md 4a5d77b88ae7cf0a0d8d39fe2579eb68bf33059a
> include/mesos/mesos.proto 50a5caf2623fff7d371753cbc6e842779fbf9769
> include/mesos/v1/mesos.proto 9d47a8a3a2f10fa493b4db35a73f33e6ee1ac727
> src/master/allocator/mesos/hierarchical.cpp f021c34ef11aac42026ba39c5a1b775794982035
>
>
> Diff: https://reviews.apache.org/r/60525/diff/7/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Gastón Kleiman
>
>