[GitHub] yingdachen commented on a change in pull request #6739: [FLINK-10289] [JobManager] Classify Exceptions to different category for apply different failover strategy

[GitBox <gi...@apache.org>]

yingdachen commented on a change in pull request #6739: [FLINK-10289] [JobManager] Classify Exceptions to different category for apply different failover strategy
URL: https://github.com/apache/flink/pull/6739#discussion_r221073384
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/throwable/ThrowableType.java
 ##########
 @@ -0,0 +1,45 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.runtime.throwable;
+
+/**
+ * */
+public enum ThrowableType {
+
+	/**
+	 * the issue indicate it will not success even retry, such as a DivideZeroException.
 
 Review comment:
   this indicates error that would not succeed even with retry, such as DivideZeroExeception. No failover should be attempted with such error. Instead, the job should fail immediately.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services