You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2020/08/12 21:56:03 UTC

[GitHub] [trafficserver] zizhong commented on a change in pull request #7100: Fixes uninitialized variables found by Xcode

zizhong commented on a change in pull request #7100:
URL: https://github.com/apache/trafficserver/pull/7100#discussion_r469569184



##########
File path: proxy/http/HttpTransactCache.cc
##########
@@ -1309,7 +1309,7 @@ HttpTransactCache::match_response_to_request_conditionals(HTTPHdr *request, HTTP
 
   // If-Match: must match strongly //
   if (request->presence(MIME_PRESENCE_IF_MATCH)) {
-    int raw_etags_len, comma_sep_tag_list_len;
+    int raw_etags_len, comma_sep_tag_list_len = 0;

Review comment:
       I agreed on what @maskit suggested.
   1. Let's separate the declarations one per line.
   2.  and initialize each of them.
   That way is much clearer than the current code.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org