You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hop.apache.org by GitBox <gi...@apache.org> on 2022/11/16 14:53:42 UTC
[GitHub] [hop] shlxue opened a new pull request, #1798: HOP-4597: Ignore variant value and script code when match default locale
shlxue opened a new pull request, #1798:
URL: https://github.com/apache/hop/pull/1798
The current localeCodes only contains: language and country.
[JDK 11 Supported Locales](https://www.oracle.com/java/technologies/javase/jdk11-suported-locales.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hop] hansva commented on pull request #1798: HOP-4597: Ignore variant value and script code when match default locale
Posted by GitBox <gi...@apache.org>.
hansva commented on PR #1798:
URL: https://github.com/apache/hop/pull/1798#issuecomment-1317244448
thanks for testing this out! I thought the error was because of the hop-config.json we added by default. but I checked and the defaultlocale is not in there !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hop] shlxue commented on pull request #1798: HOP-4597: Ignore variant value and script code when match default locale
Posted by GitBox <gi...@apache.org>.
shlxue commented on PR #1798:
URL: https://github.com/apache/hop/pull/1798#issuecomment-1317206034
If the file(hop-config.json) not exist, or not found key LocaleDefault(STRING_DEFAULT_LOCALE) in the config file.
we should automatically match the environment language.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hop] shlxue commented on pull request #1798: HOP-4597: Ignore variant value and script code when match default locale
Posted by GitBox <gi...@apache.org>.
shlxue commented on PR #1798:
URL: https://github.com/apache/hop/pull/1798#issuecomment-1317219282
In Chinese environment: Locale.getDefault().toString() return: zh_CN_#Hans
But in GlobalMessages.localeCodes: zh_CN
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hop] shlxue commented on pull request #1798: HOP-4597: Ignore variant value and script code when match default locale
Posted by GitBox <gi...@apache.org>.
shlxue commented on PR #1798:
URL: https://github.com/apache/hop/pull/1798#issuecomment-1317210935
When found key LocaleDefault(STRING_DEFAULT_LOCALE) in hop-config.json, It work fine.
But I found that some users would clear the config directory.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hop] hansva commented on pull request #1798: HOP-4597: Ignore variant value and script code when match default locale
Posted by GitBox <gi...@apache.org>.
hansva commented on PR #1798:
URL: https://github.com/apache/hop/pull/1798#issuecomment-1317170729
isn't the fact that `String defaultLocaleString = HopConfig.readOptionString(STRING_DEFAULT_LOCALE, null);` returns the value from our default hop-config.json the issue that is goes to english?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hop] hansva merged pull request #1798: HOP-4597: Ignore variant value and script code when match default locale
Posted by GitBox <gi...@apache.org>.
hansva merged PR #1798:
URL: https://github.com/apache/hop/pull/1798
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org