You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/08/19 10:16:52 UTC
[GitHub] [airflow] phanikumv opened a new pull request, #25816: Implement `EmrEksCreateClusterOperator`
phanikumv opened a new pull request, #25816:
URL: https://github.com/apache/airflow/pull/25816
This PR adds the implementation for a new operator called `EmrEksCreateClusterOperator` , which allows the users the ability to create an Amazon EMR on EKS virtual cluster. Currently we only have the ability to submit jobs on EMR EKS virtual clusters.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] vincbeck commented on a diff in pull request #25816: Implement `EmrEksCreateClusterOperator`
Posted by GitBox <gi...@apache.org>.
vincbeck commented on code in PR #25816:
URL: https://github.com/apache/airflow/pull/25816#discussion_r950317110
##########
docs/apache-airflow-providers-amazon/operators/emr_eks.rst:
##########
@@ -31,8 +31,33 @@ Prerequisite Tasks
Operators
---------
+
+.. _howto/operator:EmrEksCreateClusterOperator:
+
+
+Create an Amazon EMR EKS virtual cluster
+========================================
+
+
+The ``EmrEksCreateClusterOperator`` will create an Amazon EMR on EKS virtual cluster.
+The example DAG below shows how to create an EMR on EKS virtual cluster.
+
+To create an Amazon EMR cluster on Amazon EKS, you need to specify a virtual cluster name,
+the eks cluster that you would like to use , and an eks namespace.
+
+Refer to the `EMR on EKS Development guide <https://docs.aws.amazon.com/emr/latest/EMR-on-EKS-DevelopmentGuide/virtual-cluster.html>`__
+for more details.
+
+.. exampleinclude:: /../../airflow/providers/amazon/aws/example_dags/example_emr_eks.py
+ :language: python
Review Comment:
It removes the indentation from the code
```suggestion
:language: python
:dedent: 4
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #25816: Implement `EmrEksCreateClusterOperator`
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #25816:
URL: https://github.com/apache/airflow/pull/25816#issuecomment-1222824849
> if you can create, probably you also want to add delete
Dapends ;) If you are cloud service provider, create works best :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #25816: Implement `EmrEksCreateClusterOperator`
Posted by GitBox <gi...@apache.org>.
potiuk merged PR #25816:
URL: https://github.com/apache/airflow/pull/25816
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #25816: Implement `EmrEksCreateClusterOperator`
Posted by GitBox <gi...@apache.org>.
ashb commented on PR #25816:
URL: https://github.com/apache/airflow/pull/25816#issuecomment-1220721100
@phanikumv Yes, I got that.
I was asking if it made sense to have something lie `EmrCreateClusterOperator(task_id='a', cluster_type='virtual')` etc rather than a whole second operator. (It may not make sense. But that's what I'm asking)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] phanikumv commented on pull request #25816: Implement `EmrEksCreateClusterOperator`
Posted by GitBox <gi...@apache.org>.
phanikumv commented on PR #25816:
URL: https://github.com/apache/airflow/pull/25816#issuecomment-1220699874
> It's been a while since I looked at EMR, but is there a reason this needs to/should be a whole new operator, instead of just some new flags/arguments/mode to the existing Create EMR operator?
@ashb - This is for creating a virtual EMR cluster on an EKS namespace, not the regular EMR cluster , which runs on EC2 machines
<img width="169" alt="image" src="https://user-images.githubusercontent.com/94376113/185631825-b2bea805-cd63-4140-9f5b-c91e9bed5a78.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #25816: Implement `EmrEksCreateClusterOperator`
Posted by GitBox <gi...@apache.org>.
ashb commented on PR #25816:
URL: https://github.com/apache/airflow/pull/25816#issuecomment-1220687672
It's been a while since I looked at EMR, but is there a reason this needs to/should be a whole new operator, instead of just some new flags/arguments/mode to the existing Create EMR operator?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org