You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@subversion.apache.org by ph...@apache.org on 2015/01/19 17:11:59 UTC

svn commit: r1653039 - /subversion/trunk/subversion/svnadmin/svnadmin.c

Author: philip
Date: Mon Jan 19 16:11:59 2015
New Revision: 1653039

URL: http://svn.apache.org/r1653039
Log:
* subversion/svnadmin/svnadmin.c
  (subcommand_freeze): Allocate correct size of array, fixes invalid
   memory read identified by valgrind.

Modified:
    subversion/trunk/subversion/svnadmin/svnadmin.c

Modified: subversion/trunk/subversion/svnadmin/svnadmin.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/svnadmin/svnadmin.c?rev=1653039&r1=1653038&r2=1653039&view=diff
==============================================================================
--- subversion/trunk/subversion/svnadmin/svnadmin.c (original)
+++ subversion/trunk/subversion/svnadmin/svnadmin.c Mon Jan 19 16:11:59 2015
@@ -1271,7 +1271,7 @@ subcommand_freeze(apr_getopt_t *os, void
     }
 
   b.command = APR_ARRAY_IDX(args, 0, const char *);
-  b.args = apr_palloc(pool, sizeof(char *) * args->nelts + 1);
+  b.args = apr_palloc(pool, sizeof(char *) * (args->nelts + 1));
   for (i = 0; i < args->nelts; ++i)
     b.args[i] = APR_ARRAY_IDX(args, i, const char *);
   b.args[args->nelts] = NULL;