You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/06/14 02:25:00 UTC
[GitHub] [incubator-doris] JNSimba opened a new pull request, #10110: [improvement][config] change be 2pc config enbale defalut
JNSimba opened a new pull request, #10110:
URL: https://github.com/apache/incubator-doris/pull/10110
# Proposed changes
Issue Number: close #xxx
## Problem Summary:
default disable_stream_load_2pc=false
## Checklist(Required)
1. Does it affect the original behavior: (Yes/No/I Don't know)
2. Has unit tests been added: (Yes/No/No Need)
3. Has document been added or modified: (Yes/No/No Need)
4. Does it need to update dependencies: (Yes/No)
5. Are there any changes that cannot be rolled back: (Yes/No)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on pull request #10110: [improvement][config] change be 2pc config enbale defalut
Posted by GitBox <gi...@apache.org>.
morningman commented on PR #10110:
URL: https://github.com/apache/incubator-doris/pull/10110#issuecomment-1154978638
If it has been tested, I think we can merge this into 1.1. So that we can match the new version of flink-connector in next release.
@yiguolei please add dev-1.0.1 label if it looks good to you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] yiguolei merged pull request #10110: [improvement][config] change be 2pc config enbale defalut
Posted by GitBox <gi...@apache.org>.
yiguolei merged PR #10110:
URL: https://github.com/apache/incubator-doris/pull/10110
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #10110: [improvement][config] change be 2pc config enbale defalut
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #10110:
URL: https://github.com/apache/incubator-doris/pull/10110#issuecomment-1154710102
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #10110: [improvement][config] change be 2pc config enbale defalut
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #10110:
URL: https://github.com/apache/incubator-doris/pull/10110#issuecomment-1154710065
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] JNSimba commented on pull request #10110: [improvement][config] change be 2pc config enbale defalut
Posted by GitBox <gi...@apache.org>.
JNSimba commented on PR #10110:
URL: https://github.com/apache/incubator-doris/pull/10110#issuecomment-1154902896
> Why enable this by default? I think it has not been fully tested.
At present, the latest version of flink doris connector is submitted in 2pc mode to ensure the exactly once semantics of doris storage. We have done a lot of tests based on this, and there is no problem at present, so we hope that from the 1.1 version of doris, this configuration will be turned on by default.
On the other hand, even if this configuration is enabled by default, it has no effect on the normal streamload, because the 2pc streamload also needs to be displayed in the header to declare that 2pc is enabled
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on pull request #10110: [improvement][config] change be 2pc config enbale defalut
Posted by GitBox <gi...@apache.org>.
morningman commented on PR #10110:
URL: https://github.com/apache/incubator-doris/pull/10110#issuecomment-1154981382
BYW, @JNSimba , have you test the abnormal cases? Such as failed to submit `commit` command after first phase is done?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #10110: [improvement][config] change be 2pc config enbale defalut
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #10110:
URL: https://github.com/apache/incubator-doris/pull/10110#issuecomment-1155864727
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] JNSimba commented on pull request #10110: [improvement][config] change be 2pc config enbale defalut
Posted by GitBox <gi...@apache.org>.
JNSimba commented on PR #10110:
URL: https://github.com/apache/incubator-doris/pull/10110#issuecomment-1155016915
> BYW, @JNSimba , have you test the abnormal cases? Such as failed to submit `commit` command after first phase is done?
If the precommit succeeds, and the commit fails, the data is not visible, and the transaction expires after 12 hours.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org