You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/07/22 10:10:50 UTC
[GitHub] [airflow] potiuk opened a new pull request, #25229: Protect against the case when emulated Python is used on M1s
potiuk opened a new pull request, #25229:
URL: https://github.com/apache/airflow/pull/25229
People might have an intel Python installed on M1s. This happened
already. The result of it that they (unknowingly) suffer from
10x slower speed of any Python code they use (even locally).
This also impact Breeze because we are using Python architecture
in order to determine which platform image should be used by
Breeze.
This change add big, fat warning and 20 seconds of delay asking
the user if they REALLY want to run Breeze command using emulated
Python. If they answer y - it will continue. If they do not answer
or answer anything else, the command will error out.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #25229: Protect against the case when emulated Python is used on M1s
Posted by GitBox <gi...@apache.org>.
potiuk merged PR #25229:
URL: https://github.com/apache/airflow/pull/25229
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #25229: Protect against the case when emulated Python is used on M1s
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #25229:
URL: https://github.com/apache/airflow/pull/25229#issuecomment-1192833059
Interesting ... It's too easy to run Intel stuff on M1 and people **might** not realise they are running something 10x slower and with battery used 5x faster than they could :). We should help them realise that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #25229: Protect against the case when emulated Python is used on M1s
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #25229:
URL: https://github.com/apache/airflow/pull/25229#issuecomment-1192412607
cc: @phanikumv
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #25229: Protect against the case when emulated Python is used on M1s
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #25229:
URL: https://github.com/apache/airflow/pull/25229#issuecomment-1192480424
This is the warning you will get if you attempt to use breeze in "Intel based IDE" on M1:
<img width="793" alt="Screenshot 2022-07-22 at 13 33 41" src="https://user-images.githubusercontent.com/595491/180430997-100eedfe-4b5d-4237-8998-30760d6e419d.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org