[GitHub] couchdb issue #425: Improve reduce function overlow handling

[kxepal <gi...@git.apache.org>]

Github user kxepal commented on the issue:

    https://github.com/apache/couchdb/pull/425
  
    -1
    
    Two problems:
    
    1. Boolean `reduce_limit` flag eventually starts taking string value "log". Things should be consistent and behaviour should be predictable. Here is not the case.
    
     2. `reduce_line` is truncated with a reason.  For instance, to not blow the browser when it get the MiBs of data back. But here you also add `input_line` as  is which is much longer than `reduce_line` by the design. So things will be get more terrible.  With `reduce_limit = "log"` you can also eventually cause high IO activity since all these data will get dumped on log file no matter that debug logs are turned off.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---