[GitHub] [fineract] thesmallstar edited a comment on pull request #943: FINERACT-1006 Added spotless to auto format source code

[GitBox <gi...@apache.org>]

thesmallstar edited a comment on pull request #943:
URL: https://github.com/apache/fineract/pull/943#issuecomment-637824763


   For 2,3,4:
   I tried to see how many checkstyles can be automatically added through the generated XML file from your ".epf", it turned out space-related checkstyles were not automatically included. Then I found google-checks, this is just what google-java-formatter would do, and it happened to help automatically add the space-related check styles, I probably came to an incorrect conclusion of this being a bigger set and happen to use google-checks.
   
   If I am not wrong "epf" includes all preferences(also the formatting ), but XML only has formatting settings (which is required by formator). They are not interchangeable, we need to have them both. 
   And spotless won't support the epf, it only takes XML as an argument hence I made it.
   
   google-checks vs our-old-xml
   ->  Plan update, I will go around and stick to the generated XML from epf, and then add more tags as required to automate the checks from checkstyle. I was taking a very lazy approach earlier :P 
   
   I need to see more for point 3 and removing .epf, would update on that.
   
   For 5,6,7
   Good idea, working on it :) 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org