You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2020/08/18 19:01:36 UTC
[GitHub] [netbeans] jherkel opened a new pull request #2318: add tooltip with code coverage stats
jherkel opened a new pull request #2318:
URL: https://github.com/apache/netbeans/pull/2318
Add tooltip with code coverage stats to a code coverage overview window & code coverage bar
code cleanup
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi commented on pull request #2318: add tooltip with code coverage stats
Posted by GitBox <gi...@apache.org>.
lkishalmi commented on pull request #2318:
URL: https://github.com/apache/netbeans/pull/2318#issuecomment-694882793
@jherkel could you update this PR with the requested format change?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi merged pull request #2318: NETBEANS-4852 add tooltip with code coverage stats
Posted by GitBox <gi...@apache.org>.
lkishalmi merged pull request #2318:
URL: https://github.com/apache/netbeans/pull/2318
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] junichi11 commented on a change in pull request #2318: add tooltip with code coverage stats
Posted by GitBox <gi...@apache.org>.
junichi11 commented on a change in pull request #2318:
URL: https://github.com/apache/netbeans/pull/2318#discussion_r495556100
##########
File path: apisupport/apisupport.ant/manifest.mf
##########
@@ -1,6 +1,6 @@
Manifest-Version: 1.0
OpenIDE-Module: org.netbeans.modules.apisupport.ant
OpenIDE-Module-Localizing-Bundle: org/netbeans/modules/apisupport/project/Bundle.properties
-OpenIDE-Module-Specification-Version: 2.82
+OpenIDE-Module-Specification-Version: 2.81
Review comment:
Why?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] junichi11 commented on pull request #2318: add tooltip with code coverage stats
Posted by GitBox <gi...@apache.org>.
junichi11 commented on pull request #2318:
URL: https://github.com/apache/netbeans/pull/2318#issuecomment-699615238
> Is there any page on wiki how to setup formatter?
Unfortunately, no but, maybe basically, it should be no problem with default settings.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] junichi11 commented on a change in pull request #2318: add tooltip with code coverage stats
Posted by GitBox <gi...@apache.org>.
junichi11 commented on a change in pull request #2318:
URL: https://github.com/apache/netbeans/pull/2318#discussion_r491243940
##########
File path: ide/gsf.codecoverage/src/org/netbeans/modules/gsf/codecoverage/CoverageReportTopComponent.java
##########
@@ -399,19 +405,26 @@ public CoverageTableModel(List<FileCoverageSummary> results) {
}
this.results = results;
}
+
+ FileCoverageSummary getCoverageSummary() {
+ return total;
Review comment:
Please format.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi commented on pull request #2318: NETBEANS-4852 add tooltip with code coverage stats
Posted by GitBox <gi...@apache.org>.
lkishalmi commented on pull request #2318:
URL: https://github.com/apache/netbeans/pull/2318#issuecomment-709448095
Well Travis seems to be happy with this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] jherkel commented on a change in pull request #2318: NETBEANS-4852 add tooltip with code coverage stats
Posted by GitBox <gi...@apache.org>.
jherkel commented on a change in pull request #2318:
URL: https://github.com/apache/netbeans/pull/2318#discussion_r495601004
##########
File path: apisupport/apisupport.ant/manifest.mf
##########
@@ -1,6 +1,6 @@
Manifest-Version: 1.0
OpenIDE-Module: org.netbeans.modules.apisupport.ant
OpenIDE-Module-Localizing-Bundle: org/netbeans/modules/apisupport/project/Bundle.properties
-OpenIDE-Module-Specification-Version: 2.82
+OpenIDE-Module-Specification-Version: 2.81
Review comment:
I accidentally made a wrong commit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] jherkel commented on pull request #2318: add tooltip with code coverage stats
Posted by GitBox <gi...@apache.org>.
jherkel commented on pull request #2318:
URL: https://github.com/apache/netbeans/pull/2318#issuecomment-695808880
Sorry for the late response, I wasn't at my computer. Is there any page on wiki how to setup formatter? I will also create JIRA task for this pull request
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi commented on pull request #2318: add tooltip with code coverage stats
Posted by GitBox <gi...@apache.org>.
lkishalmi commented on pull request #2318:
URL: https://github.com/apache/netbeans/pull/2318#issuecomment-689888866
Is it possible to create a JIRA improvement issue for this one, also a screenshot of the change would be welcome. That might go into the new features/improvements page later.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] junichi11 commented on a change in pull request #2318: add tooltip with code coverage stats
Posted by GitBox <gi...@apache.org>.
junichi11 commented on a change in pull request #2318:
URL: https://github.com/apache/netbeans/pull/2318#discussion_r491243880
##########
File path: ide/gsf.codecoverage/src/org/netbeans/modules/gsf/codecoverage/CoverageReportTopComponent.java
##########
@@ -168,6 +168,9 @@
// }
totalCoverage.setCoveragePercentage(model.getTotalCoverage());
+ FileCoverageSummary summary = model.getCoverageSummary();
+ totalCoverage.setStats(summary.getLineCount(),summary.getExecutedLineCount(),
+ summary.getPartialCount(),summary.getInferredCount());
Review comment:
Please format.
##########
File path: ide/gsf.codecoverage/src/org/netbeans/modules/gsf/codecoverage/CoverageReportTopComponent.java
##########
@@ -361,6 +364,9 @@ void updateData(List<FileCoverageSummary> results) {
model = new CoverageTableModel(results);
table.setModel(model);
totalCoverage.setCoveragePercentage(model.getTotalCoverage());
+ FileCoverageSummary summary = model.getCoverageSummary();
+ totalCoverage.setStats(summary.getLineCount(),summary.getExecutedLineCount(),
+ summary.getPartialCount(),summary.getInferredCount());
Review comment:
Please format.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] jherkel commented on pull request #2318: add tooltip with code coverage stats
Posted by GitBox <gi...@apache.org>.
jherkel commented on pull request #2318:
URL: https://github.com/apache/netbeans/pull/2318#issuecomment-695808880
Sorry for the late response, I wasn't at my computer. Is there any page on wiki how to setup formatter? I will also create JIRA task for this pull request
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] junichi11 commented on a change in pull request #2318: add tooltip with code coverage stats
Posted by GitBox <gi...@apache.org>.
junichi11 commented on a change in pull request #2318:
URL: https://github.com/apache/netbeans/pull/2318#discussion_r486704591
##########
File path: ide/gsf.codecoverage/src/org/netbeans/modules/gsf/codecoverage/CoverageBar.java
##########
@@ -55,9 +59,25 @@
private boolean selected;
/** Coverage percentage: 0.0f <= x <= 100f */
private float coveragePercentage;
-
+ private int totalLines;
+ private int executedLines;
+ private int partialLines;
+ private int inferredLines;
+
public CoverageBar() {
- updateUI();
+ addHierarchyListener(new HierarchyListener() {
+ @Override
+ public void hierarchyChanged(HierarchyEvent e) {
+ if ((e.getChangeFlags() & HierarchyEvent.SHOWING_CHANGED) != 0) {
+ if (isShowing()) {
+ ToolTipManager.sharedInstance().registerComponent(CoverageBar.this);
+ } else {
+ ToolTipManager.sharedInstance().unregisterComponent(CoverageBar.this);
+ }
+ }
+ }
+ });
+ updateUI();
Review comment:
Please format. (4 spaces)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists