You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@dubbo.apache.org by Ian Luo <ia...@gmail.com> on 2018/10/29 09:46:26 UTC
[DISCUSS] should we include gson support in main trunk
Hi folks,
Today I noticed there's one pull request 2699 (dubbo Add a new
serialization -gson) [1] pending for review. I'm hesitate to move it in
since we've already had fastjson serialization support which serves the
same purpose.
I'd like to hear your opinion on this.
Thanks,
-Ian.
1. https://github.com/apache/incubator-dubbo/pull/2699
Re: [DISCUSS] should we include gson support in main trunk
Posted by jun liu <ke...@gmail.com>.
Great to have a new serialization extension!
> I'm hesitate to move it in
> since we've already had fastjson serialization support which serves the
> same purpose.
Thanks to Dubbo’s SPI, we can extend as many serialization protocol as we want. I think the existing fastjson should never be the reason to block this one from being accepted into the eco-system.
Best regards,
Jun
> On Nov 1, 2018, at 1:25 PM, Ian Luo <ia...@gmail.com> wrote:
>
> I've checked in gson support to
> https://github.com/dubbo/dubbo-serialization-gson. I also left message on
> the original pull request to invite the original author to join. Hope he
> can give me a reply soon.
>
> Regards,
> -Ian.
>
> On Thu, Nov 1, 2018 at 10:46 AM Ian Luo <ia...@gmail.com> wrote:
>
>> I failed to get response from the original author. I plan to revise his
>> impl and put it in eco system, to provide community an alternative on json
>> support. I hope the original author can come back to work with me together
>> later.
>>
>> -Ian.
>>
>> On Thu, Nov 1, 2018 at 10:21 AM yuhang xiu <ca...@gmail.com> wrote:
>>
>>> Agree with u.
>>> The serialization method of json is also much slower than hessian and
>>> kryo,
>>> and the data is relatively large. We don't have to support all json
>>> serialization. But just put it into ecosystem.
>>>
>>> YunKun Huang <hy...@apache.org> 于2018年11月1日周四 上午10:17写道：
>>>
>>>> For same purpose I prefer to have only one implement.
>>>>
>>>> And for fastjson and gson, it's hard to make decision which one is
>>> better,
>>>> since we already had fastjson in master, gson support can be part of
>>>> ecosystem but not in master
>>>>
>>>>
>>>> On 2018/10/29 09:46:26, Ian Luo <ia...@gmail.com> wrote:
>>>>> Hi folks,
>>>>>
>>>>> Today I noticed there's one pull request 2699 (dubbo Add a new
>>>>> serialization -gson) [1] pending for review. I'm hesitate to move it
>>> in
>>>>> since we've already had fastjson serialization support which serves
>>> the
>>>>> same purpose.
>>>>>
>>>>> I'd like to hear your opinion on this.
>>>>>
>>>>> Thanks,
>>>>> -Ian.
>>>>>
>>>>>
>>>>> 1. https://github.com/apache/incubator-dubbo/pull/2699
>>>>>
>>>>
>>>
>>
Re: [DISCUSS] should we include gson support in main trunk
Posted by Ian Luo <ia...@gmail.com>.
I've checked in gson support to
https://github.com/dubbo/dubbo-serialization-gson. I also left message on
the original pull request to invite the original author to join. Hope he
can give me a reply soon.
Regards,
-Ian.
On Thu, Nov 1, 2018 at 10:46 AM Ian Luo <ia...@gmail.com> wrote:
> I failed to get response from the original author. I plan to revise his
> impl and put it in eco system, to provide community an alternative on json
> support. I hope the original author can come back to work with me together
> later.
>
> -Ian.
>
> On Thu, Nov 1, 2018 at 10:21 AM yuhang xiu <ca...@gmail.com> wrote:
>
>> Agree with u.
>> The serialization method of json is also much slower than hessian and
>> kryo,
>> and the data is relatively large. We don't have to support all json
>> serialization. But just put it into ecosystem.
>>
>> YunKun Huang <hy...@apache.org> 于2018年11月1日周四 上午10:17写道：
>>
>> > For same purpose I prefer to have only one implement.
>> >
>> > And for fastjson and gson, it's hard to make decision which one is
>> better,
>> > since we already had fastjson in master, gson support can be part of
>> > ecosystem but not in master
>> >
>> >
>> > On 2018/10/29 09:46:26, Ian Luo <ia...@gmail.com> wrote:
>> > > Hi folks,
>> > >
>> > > Today I noticed there's one pull request 2699 (dubbo Add a new
>> > > serialization -gson) [1] pending for review. I'm hesitate to move it
>> in
>> > > since we've already had fastjson serialization support which serves
>> the
>> > > same purpose.
>> > >
>> > > I'd like to hear your opinion on this.
>> > >
>> > > Thanks,
>> > > -Ian.
>> > >
>> > >
>> > > 1. https://github.com/apache/incubator-dubbo/pull/2699
>> > >
>> >
>>
>
Re: [DISCUSS] should we include gson support in main trunk
Posted by Ian Luo <ia...@gmail.com>.
I failed to get response from the original author. I plan to revise his
impl and put it in eco system, to provide community an alternative on json
support. I hope the original author can come back to work with me together
later.
-Ian.
On Thu, Nov 1, 2018 at 10:21 AM yuhang xiu <ca...@gmail.com> wrote:
> Agree with u.
> The serialization method of json is also much slower than hessian and kryo,
> and the data is relatively large. We don't have to support all json
> serialization. But just put it into ecosystem.
>
> YunKun Huang <hy...@apache.org> 于2018年11月1日周四 上午10:17写道：
>
> > For same purpose I prefer to have only one implement.
> >
> > And for fastjson and gson, it's hard to make decision which one is
> better,
> > since we already had fastjson in master, gson support can be part of
> > ecosystem but not in master
> >
> >
> > On 2018/10/29 09:46:26, Ian Luo <ia...@gmail.com> wrote:
> > > Hi folks,
> > >
> > > Today I noticed there's one pull request 2699 (dubbo Add a new
> > > serialization -gson) [1] pending for review. I'm hesitate to move it in
> > > since we've already had fastjson serialization support which serves the
> > > same purpose.
> > >
> > > I'd like to hear your opinion on this.
> > >
> > > Thanks,
> > > -Ian.
> > >
> > >
> > > 1. https://github.com/apache/incubator-dubbo/pull/2699
> > >
> >
>
Re: [DISCUSS] should we include gson support in main trunk
Posted by yuhang xiu <ca...@gmail.com>.
Agree with u.
The serialization method of json is also much slower than hessian and kryo,
and the data is relatively large. We don't have to support all json
serialization. But just put it into ecosystem.
YunKun Huang <hy...@apache.org> 于2018年11月1日周四 上午10:17写道：
> For same purpose I prefer to have only one implement.
>
> And for fastjson and gson, it's hard to make decision which one is better,
> since we already had fastjson in master, gson support can be part of
> ecosystem but not in master
>
>
> On 2018/10/29 09:46:26, Ian Luo <ia...@gmail.com> wrote:
> > Hi folks,
> >
> > Today I noticed there's one pull request 2699 (dubbo Add a new
> > serialization -gson) [1] pending for review. I'm hesitate to move it in
> > since we've already had fastjson serialization support which serves the
> > same purpose.
> >
> > I'd like to hear your opinion on this.
> >
> > Thanks,
> > -Ian.
> >
> >
> > 1. https://github.com/apache/incubator-dubbo/pull/2699
> >
>
Re: [DISCUSS] should we include gson support in main trunk
Posted by YunKun Huang <hy...@apache.org>.
For same purpose I prefer to have only one implement.
And for fastjson and gson, it's hard to make decision which one is better, since we already had fastjson in master, gson support can be part of ecosystem but not in master
On 2018/10/29 09:46:26, Ian Luo <ia...@gmail.com> wrote:
> Hi folks,
>
> Today I noticed there's one pull request 2699 (dubbo Add a new
> serialization -gson) [1] pending for review. I'm hesitate to move it in
> since we've already had fastjson serialization support which serves the
> same purpose.
>
> I'd like to hear your opinion on this.
>
> Thanks,
> -Ian.
>
>
> 1. https://github.com/apache/incubator-dubbo/pull/2699
>