You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@shindig.apache.org by jo...@gmail.com on 2009/06/10 01:41:27 UTC

Per-browser rpc.js [#2]

Reviewers: shindig.remailer_gmail.com,

Description:
Updated w/ private Cache-Control headers to prevent CDN proxying issues.

[original description]
Implementation of JsFeatureLoader that loads only the rpc.js transport
code
needed by the target browser.

To use this, a concrete implementation of UserAgent.Parser must be
provided and
bound. In addition, JsFeatureLoader must be bound to implementation
SmartRpcJsFeatureLoader.

This code is not widely tested, and should be deemed experimental.

Please review this at http://codereview.appspot.com/63225

Affected files:
    
java/common/src/main/java/org/apache/shindig/common/servlet/HttpServletUserAgentProvider.java
   java/common/src/main/java/org/apache/shindig/common/servlet/UserAgent.java
    
java/common/src/test/java/org/apache/shindig/common/servlet/HttpServletUserAgentProviderTest.java
    
java/common/src/test/java/org/apache/shindig/common/servlet/UserAgentTest.java
   java/gadgets/src/main/java/org/apache/shindig/gadgets/JsLibrary.java
    
java/gadgets/src/main/java/org/apache/shindig/gadgets/SmartRpcJsFeatureLoader.java
    
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/JsServlet.java
    
java/gadgets/src/test/java/org/apache/shindig/gadgets/JsFeatureLoaderTest.java
    
java/gadgets/src/test/java/org/apache/shindig/gadgets/SmartRpcJsFeatureLoaderTest.java

Re: Per-browser rpc.js [#2]

Posted by John Hjelmstad <jo...@gmail.com>.

Still needs fleshed-out RpcJsFeatureLoaderTest.

On Tue, Jun 9, 2009 at 4:41 PM, <jo...@gmail.com> wrote:

> Reviewers: shindig.remailer_gmail.com,
>
> Description:
> Updated w/ private Cache-Control headers to prevent CDN proxying issues.
>
> [original description]
> Implementation of JsFeatureLoader that loads only the rpc.js transport
> code
> needed by the target browser.
>
> To use this, a concrete implementation of UserAgent.Parser must be
> provided and
> bound. In addition, JsFeatureLoader must be bound to implementation
> SmartRpcJsFeatureLoader.
>
> This code is not widely tested, and should be deemed experimental.
>
> Please review this at http://codereview.appspot.com/63225
>
> Affected files:
>
>  java/common/src/main/java/org/apache/shindig/common/servlet/HttpServletUserAgentProvider.java
>  java/common/src/main/java/org/apache/shindig/common/servlet/UserAgent.java
>
>  java/common/src/test/java/org/apache/shindig/common/servlet/HttpServletUserAgentProviderTest.java
>
>  java/common/src/test/java/org/apache/shindig/common/servlet/UserAgentTest.java
>  java/gadgets/src/main/java/org/apache/shindig/gadgets/JsLibrary.java
>
>  java/gadgets/src/main/java/org/apache/shindig/gadgets/SmartRpcJsFeatureLoader.java
>
>  java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/JsServlet.java
>
>  java/gadgets/src/test/java/org/apache/shindig/gadgets/JsFeatureLoaderTest.java
>
>  java/gadgets/src/test/java/org/apache/shindig/gadgets/SmartRpcJsFeatureLoaderTest.java
>
>
>