You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@texera.apache.org by "aglinxinyuan (via GitHub)" <gi...@apache.org> on 2026/07/29 11:44:45 UTC
[PR] chore(frontend): remove unused environment component and map util [texera]
aglinxinyuan opened a new pull request, #7030:
URL: https://github.com/apache/texera/pull/7030
### What changes were proposed in this PR?
Deletes three frontend files that nothing references. Pure deletion, no behaviour change: **−146 lines**.
| Removed | Lines | Why it is dead |
| --- | ---: | --- |
| `workspace/component/left-panel/environment/environment.component.ts` | 18 | contains only the ASF license header — zero statements |
| `common/util/map.ts` | 42 | `mapToRecord` / `recordToMap` have no caller |
| `common/util/map.spec.ts` | 86 | covers only the above |
`environment.component.ts` has no class, no decorator and no exports, so it cannot be declared in a module, matched by a selector, or loaded by a route. It was the only file in `environment/`, so that directory goes too.
`map.ts` predates `Object.fromEntries` and `new Map(Object.entries(...))`, both already available under the project's `lib: ES2022` setting, so nothing needs to replace it. Its spec was added by #6621, which is why the util currently looks live.
### Any related issues, documentation, discussions?
Closes #7029
### How was this PR tested?
Existing tests only — this PR adds none, since it removes files and the spec that covered them.
- `npx tsc --noEmit -p frontend/tsconfig.json` — exit 0, confirming no dangling imports.
- Checked that no build or test config enumerates the deleted paths (`angular.json`, `tsconfig*.json`, `src/test.ts`).
Verification that nothing references the removed code, re-runnable by a reviewer:
```
grep -rn "mapToRecord\|recordToMap\|EnvironmentComponent" frontend/src --include=*.ts --include=*.html --include=*.json
```
### Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Claude Opus 5)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(frontend): remove unused environment component and map util [texera]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #7030:
URL: https://github.com/apache/texera/pull/7030#issuecomment-5117895105
## [Codecov](https://app.codecov.io/gh/apache/texera/pull/7030?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 79.20%. Comparing base ([`a61702f`](https://app.codecov.io/gh/apache/texera/commit/a61702fd10ccde130f0a24a1298adff24c4a38a5?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`bc2f4f1`](https://app.codecov.io/gh/apache/texera/commit/bc2f4f12331d2bbd5078a6a2d72e47a6071960d6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #7030 +/- ##
============================================
- Coverage 79.20% 79.20% -0.01%
Complexity 3786 3786
============================================
Files 1160 1159 -1
Lines 46118 46111 -7
Branches 5114 5114
============================================
- Hits 36529 36522 -7
Misses 7969 7969
Partials 1620 1620
```
| [Flag](https://app.codecov.io/gh/apache/texera/pull/7030/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | *Carryforward flag |
|---|---|---|---|
| [access-control-service](https://app.codecov.io/gh/apache/texera/pull/7030/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `70.00% <ø> (ø)` | | Carriedforward from [a61702f](https://app.codecov.io/gh/apache/texera/commit/a61702fd10ccde130f0a24a1298adff24c4a38a5?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [agent-service](https://app.codecov.io/gh/apache/texera/pull/7030/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `76.76% <ø> (ø)` | | Carriedforward from [a61702f](https://app.codecov.io/gh/apache/texera/commit/a61702fd10ccde130f0a24a1298adff24c4a38a5?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [amber](https://app.codecov.io/gh/apache/texera/pull/7030/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `72.43% <ø> (ø)` | | Carriedforward from [a61702f](https://app.codecov.io/gh/apache/texera/commit/a61702fd10ccde130f0a24a1298adff24c4a38a5?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [computing-unit-managing-service](https://app.codecov.io/gh/apache/texera/pull/7030/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `20.49% <ø> (ø)` | | Carriedforward from [a61702f](https://app.codecov.io/gh/apache/texera/commit/a61702fd10ccde130f0a24a1298adff24c4a38a5?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [config-service](https://app.codecov.io/gh/apache/texera/pull/7030/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `66.66% <ø> (ø)` | | Carriedforward from [a61702f](https://app.codecov.io/gh/apache/texera/commit/a61702fd10ccde130f0a24a1298adff24c4a38a5?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [file-service](https://app.codecov.io/gh/apache/texera/pull/7030/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `67.21% <ø> (ø)` | | Carriedforward from [a61702f](https://app.codecov.io/gh/apache/texera/commit/a61702fd10ccde130f0a24a1298adff24c4a38a5?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [frontend](https://app.codecov.io/gh/apache/texera/pull/7030/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `83.08% <ø> (-0.01%)` | :arrow_down: | |
| [notebook-migration-service](https://app.codecov.io/gh/apache/texera/pull/7030/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `78.94% <ø> (ø)` | | Carriedforward from [a61702f](https://app.codecov.io/gh/apache/texera/commit/a61702fd10ccde130f0a24a1298adff24c4a38a5?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [pyamber](https://app.codecov.io/gh/apache/texera/pull/7030/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `96.34% <ø> (ø)` | | Carriedforward from [a61702f](https://app.codecov.io/gh/apache/texera/commit/a61702fd10ccde130f0a24a1298adff24c4a38a5?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [workflow-compiling-service](https://app.codecov.io/gh/apache/texera/pull/7030/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `26.31% <ø> (ø)` | | Carriedforward from [a61702f](https://app.codecov.io/gh/apache/texera/commit/a61702fd10ccde130f0a24a1298adff24c4a38a5?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
*This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/texera/pull/7030?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(frontend): remove unused environment component and map util [texera]
Posted by "Yicong-Huang (via GitHub)" <gi...@apache.org>.
Yicong-Huang merged PR #7030:
URL: https://github.com/apache/texera/pull/7030
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(frontend): remove unused environment component and map util [texera]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #7030:
URL: https://github.com/apache/texera/pull/7030#issuecomment-5117497720
<!-- texera-reviewer-suggestion -->
### Automated Reviewer Suggestions
Based on the `git blame` history of the changed files, we recommend the following reviewers:
- No candidates found from `git blame` history.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org