You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by StephanEwen <gi...@git.apache.org> on 2014/10/01 12:06:47 UTC
[GitHub] incubator-flink pull request: [FLINK-12] Clean up configuration ob...
GitHub user StephanEwen opened a pull request:
https://github.com/apache/incubator-flink/pull/135
[FLINK-12] Clean up configuration object
- Remove class loader (was inconsistently used and set)
- Objects are stored in their type, rather than as a string
- casting happens on object (for numbers) with fallback to parsing of the string representation
- global configuration reuses config object, rather than re-implementing config logic.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/StephanEwen/incubator-flink config
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-flink/pull/135.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #135
----
commit 4f6f3f9c8cd9f2b43068180cc32288263219d00b
Author: Stephan Ewen <se...@apache.org>
Date: 2014-09-26T15:05:50Z
[FLINK-12] Clean up configuration object
- Remove class loader (was inconsistently used and set)
- Objects are stored in their type, rather than as a string
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-flink pull request: [FLINK-12] Clean up configuration ob...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen closed the pull request at:
https://github.com/apache/incubator-flink/pull/135
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-flink pull request: [FLINK-12] Clean up configuration ob...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/incubator-flink/pull/135#issuecomment-57791642
Manually merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---