[jira] [Comment Edited] (TEZ-1372) Fix preWarm to work after recent API changes

["Bikas Saha (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TEZ-1372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14085710#comment-14085710 ] 

Bikas Saha edited comment on TEZ-1372 at 8/5/14 3:00 AM:
---------------------------------------------------------

Plan or action
1) Remove PreWarmContext and startPreWarmContainers. Use Vertex and submitDAG instead. Using Vertex seems to be the only way to keep it consistent with other changes in Vertex without replicating them in PreWarmContext. This way the user knows that they need to do the same thing with this vertex as with any other vertex in their DAG.
2) Because of 1), DAG creation moves to client. DAG name can still be used to identify pre-warm DAG.
3) The current code mentions kill prewarm dag but doesn't do it. Fix that. This would be in the AM since it knows if the current DAG is the pre-warm DAG or not and kill it. Alternatively, we could require users to check TezClient.waitTillReady() before submitting the real DAG which they anyways should be doing currently. Prefer the latter because it more consistent and less work. Typically preWarm is used in the fallow time when the application starts up.


was (Author: bikassaha):
Plan or action
1) Remove PreWarmContext and startPreWarmContainers. Use Vertex and submitDAG instead. Using Vertex seems to be the only way to keep it consistent with other changes in Vertex without replicating them in PreWarmContext.
2) Because of 1), DAG creation moves to client. DAG name can still be used to identify pre-warm DAG.
3) The current code mentions kill prewarm dag but doesn't do it. Fix that. This would be in the AM since it knows if the current DAG is the pre-warm DAG or not and kill it. Alternatively, we could require users to check TezClient.waitTillReady() before submitting the real DAG which they anyways should be doing currently. Prefer the latter because it more consistent and less work. Typically preWarm is used in the fallow time when the application starts up.

> Fix preWarm to work after recent API changes
> --------------------------------------------
>
>                 Key: TEZ-1372
>                 URL: https://issues.apache.org/jira/browse/TEZ-1372
>             Project: Apache Tez
>          Issue Type: Sub-task
>    Affects Versions: 0.5.0
>            Reporter: Bikas Saha
>            Assignee: Bikas Saha
>            Priority: Blocker
>




--
This message was sent by Atlassian JIRA
(v6.2#6252)