You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ant.apache.org by bu...@apache.org on 2011/04/11 17:00:15 UTC
DO NOT REPLY [Bug 51049] New: produces broken
"Properties >>" link
https://issues.apache.org/bugzilla/show_bug.cgi?id=51049
Summary: <junitreport> produces broken "Properties >>" link
Product: Ant
Version: 1.8.2
Platform: PC
Status: NEW
Severity: normal
Priority: P2
Component: Optional Tasks
AssignedTo: notifications@ant.apache.org
ReportedBy: markuskeller@fastmail.fm
The <junit> task from Ant 1.7.1 produced XML files where the values <property>
elements could contain newline characters, e.g.:
<property name="ant.core.lib"
value="C:\e\i\I20110127-2034-3.7M5-clean\plugins\org.apache.ant_1.7.1.v20100518-1145\lib\ant.jar"
/>
<property name="line.separator" value="
" />
The <junitreport> converted this to HTML files where the value in the
JavaScript had a single space instead of the line separator characters:
cur['line.separator'] = ' ';
This was valid JavaScript.
With Ant 1.8.2, the value in the XML got properly escaped:
<property name="ant.core.lib"
value="C:\e\i\N20110407-2000\plugins\org.apache.ant_1.8.2.v20110117-1200\lib\ant.jar"
/>
<property name="line.separator" value="
" />
But now, the <junitreport> task creates JavaScript like this, which is invalid:
cur['line.separator'] = '
';
cur['os.arch'] = 'x86';
=> There are 2 line separators in the HTML file. Should be something like:
cur['line.separator'] = '
';
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
DO NOT REPLY [Bug 51049] [PATCH] produces broken
"Properties >>" link
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=51049
Markus Keller <ma...@fastmail.fm> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |VERIFIED
--- Comment #6 from Markus Keller <ma...@fastmail.fm> 2012-01-11 17:35:10 UTC ---
Looks good, thanks. Sorry for the delay.
Tested with nightly build from
https://builds.apache.org/view/A-F/view/Ant/job/Ant_JDK_1.4/486/artifact/trunk/build/lib/
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
DO NOT REPLY [Bug 51049] [PATCH] produces broken
"Properties >>" link
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=51049
Anthony Wat <ac...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |acwwat@gmail.com
Summary|<junitreport> produces |[PATCH] <junitreport>
|broken "Properties >>" link |produces broken "Properties
| |>>" link
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 51049] [PATCH] produces broken "Properties >>"
link
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=51049
Stefan Bodewig <bo...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|VERIFIED |CLOSED
--
You are receiving this mail because:
You are the assignee for the bug.
DO NOT REPLY [Bug 51049] produces broken "Properties
>>" link
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=51049
--- Comment #3 from Anthony Wat <ac...@gmail.com> 2011-05-16 04:09:49 UTC ---
Created attachment 27001
--> https://issues.apache.org/bugzilla/attachment.cgi?id=27001
Patch for escaping newline chars properly in junit report stylesheets
The xsl files to patch are in ant/src/etc and named the same as the diffs files
respectively.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
DO NOT REPLY [Bug 51049] produces broken "Properties
>>" link
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=51049
david.stdenis@gmail.com changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |david.stdenis@gmail.com
OS/Version| |All
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 51049] [PATCH] produces broken "Properties >>"
link
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=51049
Stefan Bodewig <bo...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |dzidzitop@vfemail.net
--- Comment #7 from Stefan Bodewig <bo...@apache.org> ---
*** Bug 55425 has been marked as a duplicate of this bug. ***
--
You are receiving this mail because:
You are the assignee for the bug.
DO NOT REPLY [Bug 51049] produces broken "Properties
>>" link
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=51049
--- Comment #2 from Anthony Wat <ac...@gmail.com> 2011-05-16 03:53:58 UTC ---
It looks like the XSL stylesheets junit-frames.xsl and junit-noframes.xsl are
not escaping newline characters in the javascript sections. I found this blog
page that pretty much sums up the problem and remedy:
http://zanstra.com/base/blog/xslt_string_escape
Specifically, the stylesheets should replace 
 with \r and 
 with \n.
I'll attach a patch that involves updating the JS-escape template in the
stylesheet shortly.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
DO NOT REPLY [Bug 51049] produces broken "Properties
>>" link
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=51049
--- Comment #1 from Markus Keller <ma...@fastmail.fm> 2011-04-11 11:01:31 EDT ---
Created an attachment (id=26873)
--> (https://issues.apache.org/bugzilla/attachment.cgi?id=26873)
HTML file with broken Properties link
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
DO NOT REPLY [Bug 51049] [PATCH] produces broken
"Properties >>" link
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=51049
--- Comment #4 from Markus Keller <ma...@fastmail.fm> 2011-10-27 13:21:49 UTC ---
Ping. Could this go into 1.8.3?
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
DO NOT REPLY [Bug 51049] [PATCH] produces broken
"Properties >>" link
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=51049
Jesse Glick <jg...@netbeans.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
CC| |jglick@netbeans.org
Resolution| |FIXED
Target Milestone|--- |1.8.3
--- Comment #5 from Jesse Glick <jg...@netbeans.org> 2011-11-09 19:45:26 UTC ---
Committed revision 1199931. Please verify fix in a nightly build if you have a
moment.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.