You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joseph Wu <jo...@mesosphere.io> on 2016/04/07 00:16:42 UTC

Re: Review Request 45067: Update the long-lived-framework example.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45067/
-----------------------------------------------------------

(Updated April 6, 2016, 3:16 p.m.)


Review request for mesos, Greg Mann, Artem Harutyunyan, Kevin Klues, and Vinod Kone.


Changes
-------

Commenting changes.


Summary (updated)
-----------------

Update the long-lived-framework example.


Bugs: MESOS-5062
    https://issues.apache.org/jira/browse/MESOS-5062


Repository: mesos


Description (updated)
-------

Update the long-lived-framework example.


Diffs (updated)
-----

  src/examples/long_lived_framework.cpp ef498d63bc5f0a8deb46d71edd85a76a1d38fdd0 

Diff: https://reviews.apache.org/r/45067/diff/


Testing
-------

make check

Ran this on the master node on a Mesos cluster:
```
./long-lived-framework --master=zk://localhost:2181/mesos --executor_uri="https://s3.amazonaws.com/url/to/long-lived-executor" --executor_command="LD_LIBRARY_PATH=/path/to/libmesos && ./long-lived-executor"
```


Thanks,

Joseph Wu

Re: Review Request 45067: Updated the long-lived-framework example.

Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45067/
-----------------------------------------------------------

(Updated April 6, 2016, 4:19 p.m.)


Review request for mesos, Greg Mann, Artem Harutyunyan, Kevin Klues, and Vinod Kone.


Changes
-------

Update description to fit under 72 characters per line.


Bugs: MESOS-5062
    https://issues.apache.org/jira/browse/MESOS-5062


Repository: mesos


Description (updated)
-------

This gives the example `long-lived-framework` enough options to run 
outside of the build environment.

This also updates:

* The style of the framework code.
* Gives the `ExecutorInfo` some resources (needed for some cgroups 
  isolators).
* Restricts the framework to one agent. Otherwise, it would grab a 
  small chunk of every machine in the cluster.
* Adds filters for declined offers.


Diffs
-----

  src/examples/long_lived_framework.cpp ef498d63bc5f0a8deb46d71edd85a76a1d38fdd0 

Diff: https://reviews.apache.org/r/45067/diff/


Testing
-------

make check

Ran this on the master node on a Mesos cluster:
```
./long-lived-framework --master=zk://localhost:2181/mesos --executor_uri="https://s3.amazonaws.com/url/to/long-lived-executor" --executor_command="LD_LIBRARY_PATH=/path/to/libmesos && ./long-lived-executor"
```


Thanks,

Joseph Wu

Re: Review Request 45067: Updated the long-lived-framework example.

Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45067/
-----------------------------------------------------------

(Updated April 6, 2016, 3:34 p.m.)


Review request for mesos, Greg Mann, Artem Harutyunyan, Kevin Klues, and Vinod Kone.


Changes
-------

Accidentally reset my .reviewboardrc.  Restored description.


Summary (updated)
-----------------

Updated the long-lived-framework example.


Bugs: MESOS-5062
    https://issues.apache.org/jira/browse/MESOS-5062


Repository: mesos


Description (updated)
-------

This gives the example `long-lived-framework` enough options to run outside of the build environment.

This also updates:

* The style of the framework code.
* Gives the `ExecutorInfo` some resources (needed for some cgroups isolators).
* Restricts the framework to one agent. Otherwise, it would grab a small chunk of every machine in the cluster.
* Adds filters for declined offers.


Diffs
-----

  src/examples/long_lived_framework.cpp ef498d63bc5f0a8deb46d71edd85a76a1d38fdd0 

Diff: https://reviews.apache.org/r/45067/diff/


Testing
-------

make check

Ran this on the master node on a Mesos cluster:
```
./long-lived-framework --master=zk://localhost:2181/mesos --executor_uri="https://s3.amazonaws.com/url/to/long-lived-executor" --executor_command="LD_LIBRARY_PATH=/path/to/libmesos && ./long-lived-executor"
```


Thanks,

Joseph Wu