You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/02/03 01:39:52 UTC

[GitHub] [superset] graceguo-supercat opened a new pull request #12906: fix: Config for dataset health check

graceguo-supercat opened a new pull request #12906:
URL: https://github.com/apache/superset/pull/12906


   ### SUMMARY
   Found a couple issues when I tried to enable [dataset health check](https://github.com/apache/superset/pull/11970) in airbnb. 
   
   ### TEST PLAN
   CI and manual test
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [x] Has associated issue: #11970
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] graceguo-supercat commented on a change in pull request #12906: fix: Config for dataset health check

Posted by GitBox <gi...@apache.org>.
graceguo-supercat commented on a change in pull request #12906:
URL: https://github.com/apache/superset/pull/12906#discussion_r569046689



##########
File path: superset/config.py
##########
@@ -1100,7 +1104,3 @@ class CeleryConfig:  # pylint: disable=too-few-public-methods
     except Exception:
         logger.exception("Found but failed to import local superset_config")
         raise
-
-# It's possible to add a dataset health check logic which is specific to your system.

Review comment:
       config list below won't be able to be overwritten. Have to move it up.

##########
File path: superset/config.py
##########
@@ -1100,7 +1104,3 @@ class CeleryConfig:  # pylint: disable=too-few-public-methods
     except Exception:
         logger.exception("Found but failed to import local superset_config")
         raise
-
-# It's possible to add a dataset health check logic which is specific to your system.

Review comment:
       config list below the overwrite function won't be able to be able 
    be overwritten. Have to move it up.

##########
File path: superset/connectors/sqla/models.py
##########
@@ -704,7 +704,11 @@ def data(self) -> Dict[str, Any]:
             data_["fetch_values_predicate"] = self.fetch_values_predicate
             data_["template_params"] = self.template_params
             data_["is_sqllab_view"] = self.is_sqllab_view
-            data_["health_check_message"] = self.health_check_message
+            data_["health_check_message"] = (

Review comment:
       do not return health check message, when feature is disabled but had populated health check message before.

##########
File path: superset/connectors/sqla/models.py
##########
@@ -704,7 +704,11 @@ def data(self) -> Dict[str, Any]:
             data_["fetch_values_predicate"] = self.fetch_values_predicate
             data_["template_params"] = self.template_params
             data_["is_sqllab_view"] = self.is_sqllab_view
-            data_["health_check_message"] = self.health_check_message
+            data_["health_check_message"] = (

Review comment:
       Should not return health check message, when feature is disabled but had populated health check message before.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] graceguo-supercat commented on a change in pull request #12906: fix: Config for dataset health check

Posted by GitBox <gi...@apache.org>.
graceguo-supercat commented on a change in pull request #12906:
URL: https://github.com/apache/superset/pull/12906#discussion_r569046689



##########
File path: superset/config.py
##########
@@ -1100,7 +1104,3 @@ class CeleryConfig:  # pylint: disable=too-few-public-methods
     except Exception:
         logger.exception("Found but failed to import local superset_config")
         raise
-
-# It's possible to add a dataset health check logic which is specific to your system.

Review comment:
       config listed below the overwrite function won't be overwritten. Have to move it up.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] ktmud commented on a change in pull request #12906: fix: Config for dataset health check

Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #12906:
URL: https://github.com/apache/superset/pull/12906#discussion_r569071837



##########
File path: superset/config.py
##########
@@ -1100,7 +1104,3 @@ class CeleryConfig:  # pylint: disable=too-few-public-methods
     except Exception:
         logger.exception("Found but failed to import local superset_config")
         raise
-
-# It's possible to add a dataset health check logic which is specific to your system.

Review comment:
       Maybe add a comment block here to stop others from adding new config below this line?
   
   ```
   # -------------------------------------------------------------------
   # *                WARNING:  STOP EDITING  HERE                    *
   # -------------------------------------------------------------------
   # Don't add config values below this line since local configs won't be
   # able to override them.
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] graceguo-supercat commented on a change in pull request #12906: fix: Config for dataset health check

Posted by GitBox <gi...@apache.org>.
graceguo-supercat commented on a change in pull request #12906:
URL: https://github.com/apache/superset/pull/12906#discussion_r569078773



##########
File path: superset/config.py
##########
@@ -1100,7 +1104,3 @@ class CeleryConfig:  # pylint: disable=too-few-public-methods
     except Exception:
         logger.exception("Found but failed to import local superset_config")
         raise
-
-# It's possible to add a dataset health check logic which is specific to your system.

Review comment:
       fixed!

##########
File path: superset/connectors/sqla/models.py
##########
@@ -704,7 +704,11 @@ def data(self) -> Dict[str, Any]:
             data_["fetch_values_predicate"] = self.fetch_values_predicate
             data_["template_params"] = self.template_params
             data_["is_sqllab_view"] = self.is_sqllab_view
-            data_["health_check_message"] = self.health_check_message
+            data_["health_check_message"] = (

Review comment:
       fixed.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] ktmud merged pull request #12906: fix: Config for dataset health check

Posted by GitBox <gi...@apache.org>.
ktmud merged pull request #12906:
URL: https://github.com/apache/superset/pull/12906


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] codecov-io commented on pull request #12906: fix: Config for dataset health check

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #12906:
URL: https://github.com/apache/superset/pull/12906#issuecomment-772201417


   # [Codecov](https://codecov.io/gh/apache/superset/pull/12906?src=pr&el=h1) Report
   > Merging [#12906](https://codecov.io/gh/apache/superset/pull/12906?src=pr&el=desc) (c2fefb6) into [master](https://codecov.io/gh/apache/superset/commit/fab6238033934f84b9e3d3e36d296dc3579afb69?el=desc) (fab6238) will **decrease** coverage by `3.55%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/12906/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/superset/pull/12906?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #12906      +/-   ##
   ==========================================
   - Coverage   66.97%   63.42%   -3.56%     
   ==========================================
     Files        1026      490     -536     
     Lines       50330    30256   -20074     
     Branches     5242        0    -5242     
   ==========================================
   - Hits        33711    19189   -14522     
   + Misses      16485    11067    -5418     
   + Partials      134        0     -134     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `?` | |
   | javascript | `?` | |
   | python | `63.42% <100.00%> (-0.69%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/12906?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/config.py](https://codecov.io/gh/apache/superset/pull/12906/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.64% <100.00%> (ø)` | |
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/12906/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `84.31% <100.00%> (-6.28%)` | :arrow_down: |
   | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12906/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
   | [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/12906/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
   | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12906/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `73.84% <0.00%> (-17.31%)` | :arrow_down: |
   | [superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/12906/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `83.67% <0.00%> (-8.17%)` | :arrow_down: |
   | [superset/databases/commands/update.py](https://codecov.io/gh/apache/superset/pull/12906/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
   | [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/superset/pull/12906/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `90.62% <0.00%> (-6.25%)` | :arrow_down: |
   | [superset/databases/commands/test\_connection.py](https://codecov.io/gh/apache/superset/pull/12906/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3Rlc3RfY29ubmVjdGlvbi5weQ==) | `84.78% <0.00%> (-4.35%)` | :arrow_down: |
   | ... and [550 more](https://codecov.io/gh/apache/superset/pull/12906/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12906?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12906?src=pr&el=footer). Last update [fab6238...c2fefb6](https://codecov.io/gh/apache/superset/pull/12906?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] nytai commented on a change in pull request #12906: fix: Config for dataset health check

Posted by GitBox <gi...@apache.org>.
nytai commented on a change in pull request #12906:
URL: https://github.com/apache/superset/pull/12906#discussion_r569074453



##########
File path: superset/config.py
##########
@@ -1100,7 +1104,3 @@ class CeleryConfig:  # pylint: disable=too-few-public-methods
     except Exception:
         logger.exception("Found but failed to import local superset_config")
         raise
-
-# It's possible to add a dataset health check logic which is specific to your system.

Review comment:
       +1 for that warning, we've seen issues with config values being added after overrides are loaded. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] graceguo-supercat commented on a change in pull request #12906: fix: Config for dataset health check

Posted by GitBox <gi...@apache.org>.
graceguo-supercat commented on a change in pull request #12906:
URL: https://github.com/apache/superset/pull/12906#discussion_r569046689



##########
File path: superset/config.py
##########
@@ -1100,7 +1104,3 @@ class CeleryConfig:  # pylint: disable=too-few-public-methods
     except Exception:
         logger.exception("Found but failed to import local superset_config")
         raise
-
-# It's possible to add a dataset health check logic which is specific to your system.

Review comment:
       config listed below the overwrite function won't be able to be able 
    be overwritten. Have to move it up.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] ktmud commented on a change in pull request #12906: fix: Config for dataset health check

Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #12906:
URL: https://github.com/apache/superset/pull/12906#discussion_r569073613



##########
File path: superset/connectors/sqla/models.py
##########
@@ -704,7 +704,11 @@ def data(self) -> Dict[str, Any]:
             data_["fetch_values_predicate"] = self.fetch_values_predicate
             data_["template_params"] = self.template_params
             data_["is_sqllab_view"] = self.is_sqllab_view
-            data_["health_check_message"] = self.health_check_message
+            data_["health_check_message"] = (

Review comment:
       Maybe add this comment to code as well?
   
   ```
   # Don't return previously populated health check message in case
   # the health check feature is turned off
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org