You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/07/27 11:20:18 UTC
[GitHub] [arrow-rs] alamb opened a new pull request, #2190: Break parquet CI into its own workflow, standardize names,
alamb opened a new pull request, #2190:
URL: https://github.com/apache/arrow-rs/pull/2190
# Which issue does this PR close?
re https://github.com/apache/arrow-rs/issues/2149
# Rationale for this change
Having the CI checks broken up by crate is a prerequisite for more specific triggering them
# What changes are included in this PR?
1. Break parquet CI into its own workflow
2. Standardize testing names
3. Run clippy on each target
# Are there any user-facing changes?
<!---
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!---
If there are any breaking changes to public APIs, please add the `breaking change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] ursabot commented on pull request #2190: Break parquet CI into its own workflow, standardize step names
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #2190:
URL: https://github.com/apache/arrow-rs/pull/2190#issuecomment-1198100073
Benchmark runs are scheduled for baseline = 7199b1b2f67ba6c1ebcf343c6bbb671737cfeded and contender = 9d8f7007166dc5841d9eda640cbbecc2c43ad41f. 9d8f7007166dc5841d9eda640cbbecc2c43ad41f is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/4b0b080e258b4fdd9243fa0861d56add...0d75685ba71d441eaf6746949b0991ff/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/c528f449548b4535886fe344b5ce60e4...7a9d2d0a23d0418ea5e3efa1ebc85a00/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/dc16ab3779934178bb5eecaa75c533ec...43bea09d3bce414daa21a0101ef424f0/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/37cf6eaaccc84d1c91659aa9ad3d86fc...3fd4bb62f82d48bf8e787527f1980396/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on a diff in pull request #2190: Break parquet CI into its own workflow, standardize names,
Posted by GitBox <gi...@apache.org>.
alamb commented on code in PR #2190:
URL: https://github.com/apache/arrow-rs/pull/2190#discussion_r930940691
##########
.github/workflows/arrow_flight.yml:
##########
@@ -40,9 +40,27 @@ jobs:
uses: ./.github/actions/setup-builder
with:
rust-version: stable
- - name: Tests with default features
+ - name: Test
run: |
cargo test -p arrow-flight
- - name: Tests with all features
+ - name: Test --all-features
run: |
cargo test -p arrow-flight --all-features
+
+ clippy:
Review Comment:
I removed the `workspace` clippy check and instead ran clippy on each individual crate
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] codecov-commenter commented on pull request #2190: Break parquet CI into its own workflow, standardize step names
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #2190:
URL: https://github.com/apache/arrow-rs/pull/2190#issuecomment-1196748996
# [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/2190?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2190](https://codecov.io/gh/apache/arrow-rs/pull/2190?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (90babb8) into [master](https://codecov.io/gh/apache/arrow-rs/commit/d10d962ac85a9675c511ff8f783d1b455588d220?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d10d962) will **increase** coverage by `0.00%`.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## master #2190 +/- ##
=======================================
Coverage 82.60% 82.60%
=======================================
Files 239 239
Lines 62244 62257 +13
=======================================
+ Hits 51417 51428 +11
- Misses 10827 10829 +2
```
| [Impacted Files](https://codecov.io/gh/apache/arrow-rs/pull/2190?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [parquet/src/encodings/rle.rs](https://codecov.io/gh/apache/arrow-rs/pull/2190/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGFycXVldC9zcmMvZW5jb2RpbmdzL3JsZS5ycw==) | `92.42% <0.00%> (-0.37%)` | :arrow_down: |
| [parquet\_derive/src/parquet\_field.rs](https://codecov.io/gh/apache/arrow-rs/pull/2190/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGFycXVldF9kZXJpdmUvc3JjL3BhcnF1ZXRfZmllbGQucnM=) | `65.75% <0.00%> (-0.23%)` | :arrow_down: |
| [arrow/src/array/equal/boolean.rs](https://codecov.io/gh/apache/arrow-rs/pull/2190/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2FycmF5L2VxdWFsL2Jvb2xlYW4ucnM=) | `97.82% <0.00%> (+0.68%)` | :arrow_up: |
| [...row/src/array/builder/string\_dictionary\_builder.rs](https://codecov.io/gh/apache/arrow-rs/pull/2190/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2FycmF5L2J1aWxkZXIvc3RyaW5nX2RpY3Rpb25hcnlfYnVpbGRlci5ycw==) | `91.36% <0.00%> (+0.71%)` | :arrow_up: |
Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold merged pull request #2190: Break parquet CI into its own workflow, standardize step names
Posted by GitBox <gi...@apache.org>.
tustvold merged PR #2190:
URL: https://github.com/apache/arrow-rs/pull/2190
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on a diff in pull request #2190: Break parquet CI into its own workflow, standardize names,
Posted by GitBox <gi...@apache.org>.
alamb commented on code in PR #2190:
URL: https://github.com/apache/arrow-rs/pull/2190#discussion_r930940952
##########
.github/workflows/parquet.yml:
##########
@@ -0,0 +1,111 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+---
+# tests for parquet crate
Review Comment:
These tests were extracted from rust.yml
##########
parquet/src/encodings/rle.rs:
##########
@@ -182,6 +182,10 @@ impl RleEncoder {
self.bit_writer.bytes_written()
}
+ pub fn is_empty(&self) -> bool {
Review Comment:
Turns out clippy complains about this in parquet crate, so I fixed it
##########
.github/workflows/rust.yml:
##########
@@ -94,34 +81,6 @@ jobs:
export RUSTFLAGS="-C debuginfo=0"
cargo test
- clippy:
Review Comment:
Each of the individual crate workflows now run clippy so there is no reason to run it in the workspace as well
##########
.github/workflows/parquet.yml:
##########
@@ -0,0 +1,111 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+---
+# tests for parquet crate
+name: "parquet"
+
+on:
+ pull_request:
+
+jobs:
+ # test the crate
+ linux-test:
+ name: Test
+ runs-on: ubuntu-latest
+ container:
+ image: amd64/rust
+ env:
+ # Disable full debug symbol generation to speed up CI build and keep memory down
+ # "1" means line tables only, which is useful for panic tracebacks.
+ RUSTFLAGS: "-C debuginfo=1"
+ steps:
+ - uses: actions/checkout@v2
+ with:
+ submodules: true
+ - name: Setup Rust toolchain
+ uses: ./.github/actions/setup-builder
+ with:
+ rust-version: stable
+ - name: Test
+ run: |
+ cargo test -p parquet
+ - name: Test --all-features
+ run: |
+ cargo test -p parquet --all-features
+
+
+ # test compilaton
+ linux-features:
+ name: Check Compilation
+ runs-on: ubuntu-latest
+ container:
+ image: amd64/rust
+ env:
+ # Disable full debug symbol generation to speed up CI build and keep memory down
+ # "1" means line tables only, which is useful for panic tracebacks.
+ RUSTFLAGS: "-C debuginfo=1"
+ steps:
+ - uses: actions/checkout@v2
+ with:
+ submodules: true
+ - name: Setup Rust toolchain
+ uses: ./.github/actions/setup-builder
+ with:
+ rust-version: stable
+ - name: Check compilation
+ run: |
+ cargo check -p parquet
+ - name: Check compilation --no-default-features
+ run: |
+ cargo check -p parquet --no-default-features
+ - name: Check compilation --no-default-features --features arrow
+ run: |
+ cargo check -p parquet --no-default-features --features arrow
+ - name: Check compilation --no-default-features --all-features
+ run: |
+ cargo check -p parquet --all-features
+ - name: Check compilation --all-targets
+ run: |
+ cargo check -p parquet --all-targets
+ - name: Check compilation --no-default-features --all-targets
+ run: |
+ cargo check -p parquet --no-default-features --all-targets
+ - name: Check compilation --no-default-features --features-arrow --all-targets
+ run: |
+ cargo check -p parquet --no-default-features --features arrow --all-targets
+
+ clippy:
+ name: Clippy
+ runs-on: ubuntu-latest
+ container:
+ image: amd64/rust
+ steps:
+ - uses: actions/checkout@v2
+ - name: Setup Rust toolchain
+ uses: ./.github/actions/setup-builder
+ with:
+ rust-version: stable
+ - name: Setup Clippy
+ run: |
+ rustup component add clippy
+ - name: Run clippy
+ run: |
+ # Only run clippy for the library at this time,
+ # as there are clippy errors for other targets
+ cargo clippy -p parquet --all-features --lib -- -D warnings
+ #cargo clippy -p parquet --all-targets --all-features -- -D warnings
Review Comment:
```suggestion
# https://github.com/apache/arrow-rs/issues/1254
#cargo clippy -p parquet --all-targets --all-features -- -D warnings
```
```suggestion
#cargo clippy -p parquet --all-targets --all-features -- -D warnings
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on a diff in pull request #2190: Break parquet CI into its own workflow, standardize names,
Posted by GitBox <gi...@apache.org>.
alamb commented on code in PR #2190:
URL: https://github.com/apache/arrow-rs/pull/2190#discussion_r930940104
##########
.github/workflows/arrow.yml:
##########
@@ -77,14 +77,23 @@ jobs:
uses: ./.github/actions/setup-builder
with:
rust-version: stable
- - name: Test compilation with different features
+ - name: Check compilation
Review Comment:
By breaking each command into its own step it becomes easier to see which check failed on CI. The actual checks run are the same
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on a diff in pull request #2190: Break parquet CI into its own workflow, standardize step names
Posted by GitBox <gi...@apache.org>.
alamb commented on code in PR #2190:
URL: https://github.com/apache/arrow-rs/pull/2190#discussion_r930944041
##########
.github/workflows/parquet.yml:
##########
@@ -0,0 +1,111 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+---
+# tests for parquet crate
+name: "parquet"
+
+on:
+ pull_request:
+
+jobs:
+ # test the crate
+ linux-test:
+ name: Test
+ runs-on: ubuntu-latest
+ container:
+ image: amd64/rust
+ env:
+ # Disable full debug symbol generation to speed up CI build and keep memory down
+ # "1" means line tables only, which is useful for panic tracebacks.
+ RUSTFLAGS: "-C debuginfo=1"
+ steps:
+ - uses: actions/checkout@v2
+ with:
+ submodules: true
+ - name: Setup Rust toolchain
+ uses: ./.github/actions/setup-builder
+ with:
+ rust-version: stable
+ - name: Test
+ run: |
+ cargo test -p parquet
+ - name: Test --all-features
+ run: |
+ cargo test -p parquet --all-features
+
+
+ # test compilaton
+ linux-features:
+ name: Check Compilation
+ runs-on: ubuntu-latest
+ container:
+ image: amd64/rust
+ env:
+ # Disable full debug symbol generation to speed up CI build and keep memory down
+ # "1" means line tables only, which is useful for panic tracebacks.
+ RUSTFLAGS: "-C debuginfo=1"
+ steps:
+ - uses: actions/checkout@v2
+ with:
+ submodules: true
+ - name: Setup Rust toolchain
+ uses: ./.github/actions/setup-builder
+ with:
+ rust-version: stable
+ - name: Check compilation
+ run: |
+ cargo check -p parquet
+ - name: Check compilation --no-default-features
+ run: |
+ cargo check -p parquet --no-default-features
+ - name: Check compilation --no-default-features --features arrow
+ run: |
+ cargo check -p parquet --no-default-features --features arrow
+ - name: Check compilation --no-default-features --all-features
+ run: |
+ cargo check -p parquet --all-features
+ - name: Check compilation --all-targets
+ run: |
+ cargo check -p parquet --all-targets
+ - name: Check compilation --no-default-features --all-targets
+ run: |
+ cargo check -p parquet --no-default-features --all-targets
+ - name: Check compilation --no-default-features --features-arrow --all-targets
+ run: |
+ cargo check -p parquet --no-default-features --features arrow --all-targets
+
+ clippy:
+ name: Clippy
+ runs-on: ubuntu-latest
+ container:
+ image: amd64/rust
+ steps:
+ - uses: actions/checkout@v2
+ - name: Setup Rust toolchain
+ uses: ./.github/actions/setup-builder
+ with:
+ rust-version: stable
+ - name: Setup Clippy
+ run: |
+ rustup component add clippy
+ - name: Run clippy
+ run: |
+ # Only run clippy for the library at this time,
+ # as there are clippy errors for other targets
+ cargo clippy -p parquet --all-features --lib -- -D warnings
+ #cargo clippy -p parquet --all-targets --all-features -- -D warnings
Review Comment:
```suggestion
# https://github.com/apache/arrow-rs/issues/1254
#cargo clippy -p parquet --all-targets --all-features -- -D warnings
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org