You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-dev@hadoop.apache.org by Dhruba Borthakur <dh...@gmail.com> on 2010/12/02 08:05:01 UTC
Re: Review Request: Ability to do savenamespace without being in safemode
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/125/
-----------------------------------------------------------
(Updated 2010-12-01 23:05:00.973158)
Review request for hadoop-hdfs.
Changes
-------
This patch introduces a "force" option to the saveNamespace command. If this option is set, then the saveNamespace command is executed even if the namenode is not in safemode. The ClientProtocol number if bumped up by one.
Summary
-------
The namenode need not be in safemode while runnign the saveNamespace command. The saveNamespace command acquires the FSNamesystem writelock, thus preventing anybody else from modifying the namespace.
The lease expiry thread in the LeaseManager acquires the FSNamesystem-writelock too, so it is well protected.
This addresses bug HDFS-1508.
https://issues.apache.org/jira/browse/HDFS-1508
Diffs (updated)
-----
http://svn.apache.org/repos/asf/hadoop/hdfs/trunk/src/java/org/apache/hadoop/hdfs/DFSClient.java 1040699
http://svn.apache.org/repos/asf/hadoop/hdfs/trunk/src/java/org/apache/hadoop/hdfs/DistributedFileSystem.java 1040699
http://svn.apache.org/repos/asf/hadoop/hdfs/trunk/src/java/org/apache/hadoop/hdfs/protocol/ClientProtocol.java 1040699
http://svn.apache.org/repos/asf/hadoop/hdfs/trunk/src/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java 1040699
http://svn.apache.org/repos/asf/hadoop/hdfs/trunk/src/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java 1040699
http://svn.apache.org/repos/asf/hadoop/hdfs/trunk/src/java/org/apache/hadoop/hdfs/tools/DFSAdmin.java 1040699
http://svn.apache.org/repos/asf/hadoop/hdfs/trunk/src/test/hdfs/org/apache/hadoop/hdfs/UpgradeUtilities.java 1040699
http://svn.apache.org/repos/asf/hadoop/hdfs/trunk/src/test/hdfs/org/apache/hadoop/hdfs/server/namenode/TestEditLogRace.java 1040699
http://svn.apache.org/repos/asf/hadoop/hdfs/trunk/src/test/hdfs/org/apache/hadoop/hdfs/server/namenode/TestParallelImageWrite.java 1040699
http://svn.apache.org/repos/asf/hadoop/hdfs/trunk/src/test/hdfs/org/apache/hadoop/hdfs/server/namenode/TestSaveNamespace.java 1040699
http://svn.apache.org/repos/asf/hadoop/hdfs/trunk/src/test/hdfs/org/apache/hadoop/hdfs/server/namenode/TestStartup.java 1040699
http://svn.apache.org/repos/asf/hadoop/hdfs/trunk/src/test/hdfs/org/apache/hadoop/hdfs/tools/offlineImageViewer/TestOfflineImageViewer.java 1040699
Diff: https://reviews.apache.org/r/125/diff
Testing
-------
Unit test attached
Thanks,
Dhruba
Re: Review Request: Ability to do savenamespace without being in safemode
Posted by Dhruba Borthakur <dh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/125/
-----------------------------------------------------------
(Updated 2010-12-07 11:01:28.866525)
Review request for hadoop-hdfs.
Changes
-------
Incorporated Hairong's review comments.
Summary
-------
The namenode need not be in safemode while runnign the saveNamespace command. The saveNamespace command acquires the FSNamesystem writelock, thus preventing anybody else from modifying the namespace.
The lease expiry thread in the LeaseManager acquires the FSNamesystem-writelock too, so it is well protected.
This addresses bug HDFS-1508.
https://issues.apache.org/jira/browse/HDFS-1508
Diffs (updated)
-----
http://svn.apache.org/repos/asf/hadoop/hdfs/trunk/src/java/org/apache/hadoop/hdfs/DFSClient.java 1043158
http://svn.apache.org/repos/asf/hadoop/hdfs/trunk/src/java/org/apache/hadoop/hdfs/DistributedFileSystem.java 1043158
http://svn.apache.org/repos/asf/hadoop/hdfs/trunk/src/java/org/apache/hadoop/hdfs/protocol/ClientProtocol.java 1043158
http://svn.apache.org/repos/asf/hadoop/hdfs/trunk/src/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java 1043158
http://svn.apache.org/repos/asf/hadoop/hdfs/trunk/src/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java 1043158
http://svn.apache.org/repos/asf/hadoop/hdfs/trunk/src/java/org/apache/hadoop/hdfs/tools/DFSAdmin.java 1043158
http://svn.apache.org/repos/asf/hadoop/hdfs/trunk/src/test/hdfs/org/apache/hadoop/hdfs/UpgradeUtilities.java 1043158
http://svn.apache.org/repos/asf/hadoop/hdfs/trunk/src/test/hdfs/org/apache/hadoop/hdfs/server/namenode/TestEditLogRace.java 1043158
http://svn.apache.org/repos/asf/hadoop/hdfs/trunk/src/test/hdfs/org/apache/hadoop/hdfs/server/namenode/TestParallelImageWrite.java 1043158
http://svn.apache.org/repos/asf/hadoop/hdfs/trunk/src/test/hdfs/org/apache/hadoop/hdfs/server/namenode/TestSaveNamespace.java 1043158
http://svn.apache.org/repos/asf/hadoop/hdfs/trunk/src/test/hdfs/org/apache/hadoop/hdfs/server/namenode/TestStartup.java 1043158
http://svn.apache.org/repos/asf/hadoop/hdfs/trunk/src/test/hdfs/org/apache/hadoop/hdfs/tools/offlineImageViewer/TestOfflineImageViewer.java 1043158
Diff: https://reviews.apache.org/r/125/diff
Testing
-------
Unit test attached
Thanks,
Dhruba
Re: Review Request: Ability to do savenamespace without being in safemode
Posted by Dhruba Borthakur <dh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/125/
-----------------------------------------------------------
(Updated 2010-12-02 11:21:23.394822)
Review request for hadoop-hdfs.
Changes
-------
This addresses Konstanitin's request to add a unit test to test the invocation of saveNamespace command in the middle of a checkpoint.
Summary
-------
The namenode need not be in safemode while runnign the saveNamespace command. The saveNamespace command acquires the FSNamesystem writelock, thus preventing anybody else from modifying the namespace.
The lease expiry thread in the LeaseManager acquires the FSNamesystem-writelock too, so it is well protected.
This addresses bug HDFS-1508.
https://issues.apache.org/jira/browse/HDFS-1508
Diffs (updated)
-----
http://svn.apache.org/repos/asf/hadoop/hdfs/trunk/src/java/org/apache/hadoop/hdfs/DFSClient.java 1041540
http://svn.apache.org/repos/asf/hadoop/hdfs/trunk/src/java/org/apache/hadoop/hdfs/DistributedFileSystem.java 1041540
http://svn.apache.org/repos/asf/hadoop/hdfs/trunk/src/java/org/apache/hadoop/hdfs/protocol/ClientProtocol.java 1041540
http://svn.apache.org/repos/asf/hadoop/hdfs/trunk/src/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java 1041540
http://svn.apache.org/repos/asf/hadoop/hdfs/trunk/src/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java 1041540
http://svn.apache.org/repos/asf/hadoop/hdfs/trunk/src/java/org/apache/hadoop/hdfs/tools/DFSAdmin.java 1041540
http://svn.apache.org/repos/asf/hadoop/hdfs/trunk/src/test/hdfs/org/apache/hadoop/hdfs/UpgradeUtilities.java 1041540
http://svn.apache.org/repos/asf/hadoop/hdfs/trunk/src/test/hdfs/org/apache/hadoop/hdfs/server/namenode/TestEditLogRace.java 1041540
http://svn.apache.org/repos/asf/hadoop/hdfs/trunk/src/test/hdfs/org/apache/hadoop/hdfs/server/namenode/TestParallelImageWrite.java 1041540
http://svn.apache.org/repos/asf/hadoop/hdfs/trunk/src/test/hdfs/org/apache/hadoop/hdfs/server/namenode/TestSaveNamespace.java 1041540
http://svn.apache.org/repos/asf/hadoop/hdfs/trunk/src/test/hdfs/org/apache/hadoop/hdfs/server/namenode/TestStartup.java 1041540
http://svn.apache.org/repos/asf/hadoop/hdfs/trunk/src/test/hdfs/org/apache/hadoop/hdfs/tools/offlineImageViewer/TestOfflineImageViewer.java 1041540
Diff: https://reviews.apache.org/r/125/diff
Testing
-------
Unit test attached
Thanks,
Dhruba