You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/10/30 02:53:08 UTC
[GitHub] [spark] dongjoon-hyun opened a new pull request #30196: [SPARK-33292][SQL][2.4] Make Literal ArrayBasedMapData string representation disambiguous
dongjoon-hyun opened a new pull request #30196:
URL: https://github.com/apache/spark/pull/30196
### What changes were proposed in this pull request?
This is a backport of SPARK-33292.
This PR aims to wrap `ArrayBasedMapData` literal representation with `map(...)`.
### Why are the changes needed?
Literal ArrayBasedMapData has inconsistent string representation from `LogicalPlan` to `Optimized Logical Plan/Physical Plan`. Also, the representation at `Optimized Logical Plan` and `Physical Plan` is ambiguous like `[1 AS a#0, keys: [key1], values: [value1] AS b#1]`.
**BEFORE**
```scala
scala> spark.version
res0: String = 2.4.7
scala> sql("SELECT 1 a, map('key1', 'value1') b").explain(true)
== Parsed Logical Plan ==
'Project [1 AS a#0, 'map(key1, value1) AS b#1]
+- OneRowRelation
== Analyzed Logical Plan ==
a: int, b: map<string,string>
Project [1 AS a#0, map(key1, value1) AS b#1]
+- OneRowRelation
== Optimized Logical Plan ==
Project [1 AS a#0, keys: [key1], values: [value1] AS b#1]
+- OneRowRelation
== Physical Plan ==
*(1) Project [1 AS a#0, keys: [key1], values: [value1] AS b#1]
+- Scan OneRowRelation[]
```
**AFTER**
```scala
scala> spark.version
res0: String = 3.1.0-SNAPSHOT
scala> sql("SELECT 1 a, map('key1', 'value1') b").explain(true)
== Parsed Logical Plan ==
'Project [1 AS a#4, 'map(key1, value1) AS b#5]
+- OneRowRelation
== Analyzed Logical Plan ==
a: int, b: map<string,string>
Project [1 AS a#4, map(key1, value1) AS b#5]
+- OneRowRelation
== Optimized Logical Plan ==
Project [1 AS a#4, map(keys: [key1], values: [value1]) AS b#5]
+- OneRowRelation
== Physical Plan ==
*(1) Project [1 AS a#4, map(keys: [key1], values: [value1]) AS b#5]
+- *(1) Scan OneRowRelation[]
```
### Does this PR introduce _any_ user-facing change?
Yes. This changes the query plan's string representation in `explain` command and UI. However, this is a bug fix.
### How was this patch tested?
Pass the CI with the newly added test case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30196: [SPARK-33292][SQL][2.4] Make Literal ArrayBasedMapData string representation disambiguous
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30196:
URL: https://github.com/apache/spark/pull/30196#issuecomment-719152026
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #30196: [SPARK-33292][SQL][2.4] Make Literal ArrayBasedMapData string representation disambiguous
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #30196:
URL: https://github.com/apache/spark/pull/30196
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30196: [SPARK-33292][SQL][2.4] Make Literal ArrayBasedMapData string representation disambiguous
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30196:
URL: https://github.com/apache/spark/pull/30196#issuecomment-719152009
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35037/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30196: [SPARK-33292][SQL][2.4] Make Literal ArrayBasedMapData string representation disambiguous
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30196:
URL: https://github.com/apache/spark/pull/30196#issuecomment-719325738
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30196: [SPARK-33292][SQL][2.4] Make Literal ArrayBasedMapData string representation disambiguous
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30196:
URL: https://github.com/apache/spark/pull/30196#issuecomment-719323857
**[Test build #130432 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130432/testReport)** for PR 30196 at commit [`e579ea3`](https://github.com/apache/spark/commit/e579ea3a1e480b6793ac2af69187c8c1767e1ad1).
* This patch **fails due to an unknown error code, -9**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30196: [SPARK-33292][SQL][2.4] Make Literal ArrayBasedMapData string representation disambiguous
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30196:
URL: https://github.com/apache/spark/pull/30196#issuecomment-719139845
**[Test build #130432 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130432/testReport)** for PR 30196 at commit [`e579ea3`](https://github.com/apache/spark/commit/e579ea3a1e480b6793ac2af69187c8c1767e1ad1).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30196: [SPARK-33292][SQL][2.4] Make Literal ArrayBasedMapData string representation disambiguous
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30196:
URL: https://github.com/apache/spark/pull/30196#issuecomment-719152026
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #30196: [SPARK-33292][SQL][2.4] Make Literal ArrayBasedMapData string representation disambiguous
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #30196:
URL: https://github.com/apache/spark/pull/30196#issuecomment-719225012
Thank you, @maropu .
Merged to branch-2.4.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30196: [SPARK-33292][SQL][2.4] Make Literal ArrayBasedMapData string representation disambiguous
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30196:
URL: https://github.com/apache/spark/pull/30196#issuecomment-719325744
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/130432/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30196: [SPARK-33292][SQL][2.4] Make Literal ArrayBasedMapData string representation disambiguous
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30196:
URL: https://github.com/apache/spark/pull/30196#issuecomment-719139845
**[Test build #130432 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130432/testReport)** for PR 30196 at commit [`e579ea3`](https://github.com/apache/spark/commit/e579ea3a1e480b6793ac2af69187c8c1767e1ad1).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30196: [SPARK-33292][SQL][2.4] Make Literal ArrayBasedMapData string representation disambiguous
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30196:
URL: https://github.com/apache/spark/pull/30196#issuecomment-719148347
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35037/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30196: [SPARK-33292][SQL][2.4] Make Literal ArrayBasedMapData string representation disambiguous
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30196:
URL: https://github.com/apache/spark/pull/30196#issuecomment-719325738
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org