[jira] Commented: (WICKET-1957) Odd number of page parameters - should not throw IllegalStateException

["Ryan Donahue (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/WICKET-1957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12653945#action_12653945 ] 

Ryan Donahue commented on WICKET-1957:
--------------------------------------

We have run into this for our site utipu.com where Yahoo Slurp tries to guess URLs in the following manner:
1) Slurp encounters the following valid URL, http://www.utipu.com/some/valid/url
2) Then Slurp requests this URL http://www.utipu.com/some/valid

The consequence for us is that when the Internal Error page is served with a 200 status to Slurp, Slurp assumes it is a valid URL and continues to request this URL everytime it crawls the site.

I agree with Igor that tweaking the URL incorrectly should cause an error.  However, I think it should respond with a 404 since the request URL is really "Not Found."  Replying with a "Page Not Found" should be sufficient, especially since Wicket allows us to override the "Page Not Found" page.

> Odd number of page parameters - should not throw IllegalStateException
> ----------------------------------------------------------------------
>
>                 Key: WICKET-1957
>                 URL: https://issues.apache.org/jira/browse/WICKET-1957
>             Project: Wicket
>          Issue Type: Bug
>    Affects Versions: 1.4-RC1
>            Reporter: Stefan Simik
>            Assignee: Igor Vaynberg
>         Attachments: ExtendedBookmarkablePageRequestTargetUrlCodingStrategy.java
>
>
> The default URL strategy in wicket throws IllegalStateException, when there is odd number of parameters ?
> See AbstractRequestTargetUrlCodingStrategy: line 169 in RC1
> We have a problem with this way handling, because our users rewrite URLs manually
> (we cannot prevent users from doing this).
> Our pages are stateless and they don't use any parameters - BUT there are throwing exceptions
> and showing InternalErrorPage-s. It is presented like a serious problem like DB, or like service failed
> but there is no problem actually - only parameters, that are not used.
> I think, that page parameters should not result in INTERNAL ERROR,
> because there are many cases, where this is not relevant.
> There should be an alternative way - some custom handling or ignoring parameters in such a situation.
> The same problem is with MixedParamUrlCodingStrategy:
> (See MixedParamUrlCodingStrategy: line 181)  in RC1
> ------------------------------------------------------------------------------------
> Adding additional parameter results in exception a internal-error page.
> IMHO, additional parameters should be ignored and not result in error.
> I would suggest add the latest odd parameter to page parameters, but with empty value "".

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.