You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "snuyanzin (via GitHub)" <gi...@apache.org> on 2026/10/20 20:26:45 UTC
[PR] [FLINK-41056][table] Keep non-compact decimals with unscaled value fitting in a long as long to avoid BigDecimal on read, add, subtract, cast and deserialize [flink]
snuyanzin opened a new pull request, #29536:
URL: https://github.com/apache/flink/pull/29536
…
## What is the purpose of the change
This is a follow up on https://github.com/apache/flink/pull/29507
## Brief change log
DecimalData and deserializer
## Verifying this change
more tests are added
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): ( no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes(package private only))
- The serializers: (yes )
- The runtime per-record code paths (performance sensitive): (yes )
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable )
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR, please
change the checkbox below to `[X]` and replace the placeholder in the "Generated-by"
line with the tool name and version. Otherwise remove the "Generated-by" line.
See the ASF Generative Tooling Guidance for details:
https://www.apache.org/legal/generative-tooling.html
You are responsible for the quality and correctness of every change in this PR
regardless of the tooling used. Low-effort AI-generated PRs will be closed. See
AGENTS.md for the full guidance.
-->
- [ ] Yes (please specify the tool below)
Generated-by: [Tool Name and Version]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-41056][table] Keep non-compact decimals with unscaled value fitting in a long as long to avoid BigDecimal on read, add, subtract, cast and deserialize [flink]
Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin commented on PR #29536:
URL: https://github.com/apache/flink/pull/29536#issuecomment-6350671239
@RocMarshal thank you for the feedback
The serialized format is unchanged, so compatibleAsIs still holds. Added testDeserializeLegacyNonCompactBytes with fixed byte fixtures for 0, 127/128, -128/-129, Long.MAX/MIN and both 9-byte neighbours. It checks the value, that hashCode matches BigDecimal, and that re-serializing gives the same bytes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-41056][table] Keep non-compact decimals with unscaled value fitting in a long as long to avoid BigDecimal on read, add, subtract, cast and deserialize [flink]
Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #29536:
URL: https://github.com/apache/flink/pull/29536#issuecomment-6300998134
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d243a86be5274d76d3ad821762675d09944cb876",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d243a86be5274d76d3ad821762675d09944cb876",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d243a86be5274d76d3ad821762675d09944cb876 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-41056][table] Keep non-compact decimals with unscaled value fitting in a long as long to avoid BigDecimal on read, add, subtract, cast and deserialize [flink]
Posted by "RocMarshal (via GitHub)" <gi...@apache.org>.
RocMarshal commented on PR #29536:
URL: https://github.com/apache/flink/pull/29536#issuecomment-6355122820
Thanks @snuyanzin for the clarification
LGTM +1 now
BTW, he CI is failed due to an issue that is not related to the change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-41056][table] Keep non-compact decimals with unscaled value fitting in a long as long to avoid BigDecimal on read, add, subtract, cast and deserialize [flink]
Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin commented on PR #29536:
URL: https://github.com/apache/flink/pull/29536#issuecomment-6388443077
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-41056][table] Keep non-compact decimals with unscaled value fitting in a long as long to avoid BigDecimal on read, add, subtract, cast and deserialize [flink]
Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin commented on PR #29536:
URL: https://github.com/apache/flink/pull/29536#issuecomment-6300749874
@RocMarshal since you looked at https://github.com/apache/flink/pull/29507
can you please take a look here as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-41056][table] Keep non-compact decimals with unscaled value fitting in a long as long to avoid BigDecimal on read, add, subtract, cast and deserialize [flink]
Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin merged PR #29536:
URL: https://github.com/apache/flink/pull/29536
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org