[jira] [Updated] (HBASE-4683) Always cache index and bloom blocks

["Phabricator (Updated) (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HBASE-4683?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Phabricator updated HBASE-4683:
-------------------------------

    Attachment: D1695.1.patch

mbautin requested code review of "[jira] [HBASE-4683] Test that we always cache index and bloom blocks".
Reviewers: JIRA, jdcryans, lhofhansl, Liyin

  This was reviewed D807 but was not checked in. Submitting unit test as a separate patch, and extending the scope of the test to also handle the case when block cache is enabled for the column family.

TEST PLAN
  Run unit tests

REVISION DETAIL
  https://reviews.facebook.net/D1695

AFFECTED FILES
  src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java
  src/test/java/org/apache/hadoop/hbase/io/hfile/TestForceCacheImportantBlocks.java

MANAGE HERALD DIFFERENTIAL RULES
  https://reviews.facebook.net/herald/view/differential/

WHY DID I GET THIS EMAIL?
  https://reviews.facebook.net/herald/transcript/3621/

Tip: use the X-Herald-Rules header to filter Herald messages in your client.

                
> Always cache index and bloom blocks
> -----------------------------------
>
>                 Key: HBASE-4683
>                 URL: https://issues.apache.org/jira/browse/HBASE-4683
>             Project: HBase
>          Issue Type: New Feature
>            Reporter: Lars Hofhansl
>            Assignee: Mikhail Bautin
>            Priority: Minor
>             Fix For: 0.94.0, 0.92.0
>
>         Attachments: 0001-Cache-important-block-types.patch, 4683-v2.txt, 4683.txt, D1695.1.patch, D807.1.patch, D807.2.patch, D807.3.patch, HBASE-4683-0.92-v2.patch, HBASE-4683-v3.patch
>
>
> This would add a new boolean config option: hfile.block.cache.datablocks
> Default would be true.
> Setting this to false allows HBase in a mode where only index blocks are cached, which is useful for analytical scenarios where a useful working set of the data cannot be expected to fit into the (aggregate) cache.
> This is the equivalent of setting cacheBlocks to false on all scans (including scans on behalf of gets).
> I would like to get a general feeling about what folks think about this.
> The change itself would be simple.
> Update (Mikhail): we probably don't need a new conf option. Instead, we will make index blocks cached by default.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira