You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@linkis.apache.org by "ahaoyao (via GitHub)" <gi...@apache.org> on 2023/06/01 06:27:23 UTC

[GitHub] [linkis-website] ahaoyao opened a new pull request, #710: Change dataSourceId to dataSourceName

ahaoyao opened a new pull request, #710:
URL: https://github.com/apache/linkis-website/pull/710

   Change dataSourceId to dataSourceName


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org
For additional commands, e-mail: commits-help@linkis.apache.org

[GitHub] [linkis-website] casionone commented on a diff in pull request #710: Change dataSourceId to dataSourceName

Posted by "casionone (via GitHub)" <gi...@apache.org>.
casionone commented on code in PR #710:
URL: https://github.com/apache/linkis-website/pull/710#discussion_r1225413685


##########
i18n/zh-CN/docusaurus-plugin-content-docs-community/current/how-to-contribute-to-website.md:
##########
@@ -160,6 +160,12 @@ Visit the page https://linkis.apache.org/zh-CN/user
 ### 3.10 路径规范
 如果希望想从一个markdown文档链接到另外一个文档, 最好使用绝对路径. 例如, 如果希望链接到 `quick-deploy.md`这个文档, 路径应写成 `/docs/deployment/quick-deploy.md`。
 
+### 3.11 版本文档
+对于版本文档（即每个版本对应的文档）  
+如果是存量文档的错误（如拼写 错别字 /格式等 ）最好所有版本都调整, 包括中英文  
+如果文档的内容优化，和版本不相关（如补充的设计文档）, 更新最近的两个版本文档, 包括中英文
+如果是新版本特性文档 和版本强相关 如本次版本新增的特性说明文档, 只需要补充至最新的版本文档中, 包括中英文
+

Review Comment:
   ![image](https://github.com/apache/linkis-website/assets/7869972/c69a3f68-c218-410f-839e-02be7826467e)
   最好优化下格式 
   补充说明中/英文版本文档路径  以及最近两个版本（最新版本和下一个版本）的文档路径说明 
   
   ---
   It is best to optimize the format
   Supplementary explanation of the Chinese/English version document path and the document path description of the last two versions (the latest version and the next version)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org
For additional commands, e-mail: commits-help@linkis.apache.org

[GitHub] [linkis-website] netlify[bot] commented on pull request #710: Change dataSourceId to dataSourceName

Posted by "netlify[bot] (via GitHub)" <gi...@apache.org>.
netlify[bot] commented on PR #710:
URL: https://github.com/apache/linkis-website/pull/710#issuecomment-1571432589

   ### <span aria-hidden="true">👷</span> Deploy Preview for *apache-linkis-website* processing.
   
   
   |  Name | Link |
   |:-:|------------------------|
   |<span aria-hidden="true">🔨</span> Latest commit | 71ca5334a7ad25c05209a7f22a5fb4aa599414d7 |
   |<span aria-hidden="true">🔍</span> Latest deploy log | https://app.netlify.com/sites/apache-linkis-website/deploys/64783a4b4c93f2000840aa86 |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org
For additional commands, e-mail: commits-help@linkis.apache.org

[GitHub] [linkis-website] peacewong commented on pull request #710: Change dataSourceId to dataSourceName

Posted by "peacewong (via GitHub)" <gi...@apache.org>.
peacewong commented on PR #710:
URL: https://github.com/apache/linkis-website/pull/710#issuecomment-1572128115

   need to update zh-cn doc


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org
For additional commands, e-mail: commits-help@linkis.apache.org

[GitHub] [linkis-website] casionone merged pull request #710: Change dataSourceId to dataSourceName

Posted by "casionone (via GitHub)" <gi...@apache.org>.
casionone merged PR #710:
URL: https://github.com/apache/linkis-website/pull/710


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org
For additional commands, e-mail: commits-help@linkis.apache.org

[GitHub] [linkis-website] casionone commented on a diff in pull request #710: Change dataSourceId to dataSourceName

Posted by "casionone (via GitHub)" <gi...@apache.org>.
casionone commented on code in PR #710:
URL: https://github.com/apache/linkis-website/pull/710#discussion_r1225411233


##########
i18n/zh-CN/docusaurus-plugin-content-docs-community/current/how-to-contribute-to-website.md:
##########
@@ -160,6 +160,12 @@ Visit the page https://linkis.apache.org/zh-CN/user
 ### 3.10 路径规范
 如果希望想从一个markdown文档链接到另外一个文档, 最好使用绝对路径. 例如, 如果希望链接到 `quick-deploy.md`这个文档, 路径应写成 `/docs/deployment/quick-deploy.md`。
 
+### 3.11 版本文档
+对于版本文档（即每个版本对应的文档）  
+如果是存量文档的错误（如拼写 错别字 /格式等 ）最好所有版本都调整, 包括中英文  
+如果文档的内容优化，和版本不相关（如补充的设计文档）, 更新最近的两个版本文档, 包括中英文
+如果是新版本特性文档 和版本强相关 如本次版本新增的特性说明文档, 只需要补充至最新的版本文档中, 包括中英文
+

Review Comment:
   batter to add some example



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org
For additional commands, e-mail: commits-help@linkis.apache.org

[GitHub] [linkis-website] casionone commented on pull request #710: Change dataSourceId to dataSourceName

Posted by "casionone (via GitHub)" <gi...@apache.org>.
casionone commented on PR #710:
URL: https://github.com/apache/linkis-website/pull/710#issuecomment-1573052624

   need to update
   
   - versioned_docs/version-1.3.2/user-guide/datasource-manual.md (1.3.2)
   - docs/user-guide/datasource-client.md (next version)
   - i18n/zh-CN/docusaurus-plugin-content-docs/current/user-guide/datasource-client.md
   - i18n/zh-CN/docusaurus-plugin-content-docs/version-1.3.2/user-guide/datasource-manual.md
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org
For additional commands, e-mail: commits-help@linkis.apache.org

[GitHub] [linkis-website] ahaoyao commented on pull request #710: Change dataSourceId to dataSourceName

Posted by "ahaoyao (via GitHub)" <gi...@apache.org>.
ahaoyao commented on PR #710:
URL: https://github.com/apache/linkis-website/pull/710#issuecomment-1592425133

   > need to update zh-cn doc
   
   done


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org
For additional commands, e-mail: commits-help@linkis.apache.org

[GitHub] [linkis-website] ahaoyao commented on pull request #710: Change dataSourceId to dataSourceName

Posted by "ahaoyao (via GitHub)" <gi...@apache.org>.
ahaoyao commented on PR #710:
URL: https://github.com/apache/linkis-website/pull/710#issuecomment-1592425521

   > need to update
   > 
   > * versioned_docs/version-1.3.2/user-guide/datasource-manual.md (1.3.2)
   > * docs/user-guide/datasource-client.md (next version)
   > * i18n/zh-CN/docusaurus-plugin-content-docs/current/user-guide/datasource-client.md
   > * i18n/zh-CN/docusaurus-plugin-content-docs/version-1.3.2/user-guide/datasource-manual.md
   
   done


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org
For additional commands, e-mail: commits-help@linkis.apache.org

[GitHub] [linkis-website] casionone commented on a diff in pull request #710: Change dataSourceId to dataSourceName

Posted by "casionone (via GitHub)" <gi...@apache.org>.
casionone commented on code in PR #710:
URL: https://github.com/apache/linkis-website/pull/710#discussion_r1225411233


##########
i18n/zh-CN/docusaurus-plugin-content-docs-community/current/how-to-contribute-to-website.md:
##########
@@ -160,6 +160,12 @@ Visit the page https://linkis.apache.org/zh-CN/user
 ### 3.10 路径规范
 如果希望想从一个markdown文档链接到另外一个文档, 最好使用绝对路径. 例如, 如果希望链接到 `quick-deploy.md`这个文档, 路径应写成 `/docs/deployment/quick-deploy.md`。
 
+### 3.11 版本文档
+对于版本文档（即每个版本对应的文档）  
+如果是存量文档的错误（如拼写 错别字 /格式等 ）最好所有版本都调整, 包括中英文  
+如果文档的内容优化，和版本不相关（如补充的设计文档）, 更新最近的两个版本文档, 包括中英文
+如果是新版本特性文档 和版本强相关 如本次版本新增的特性说明文档, 只需要补充至最新的版本文档中, 包括中英文
+

Review Comment:
   batter to add some eg 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org
For additional commands, e-mail: commits-help@linkis.apache.org