You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/06/23 10:50:08 UTC

[GitHub] [arrow-rs] alamb commented on a change in pull request #488: Update rand, proc-macro and zstd dependencies

alamb commented on a change in pull request #488:
URL: https://github.com/apache/arrow-rs/pull/488#discussion_r656979521



##########
File path: arrow/Cargo.toml
##########
@@ -60,6 +63,8 @@ csv = ["csv_crate"]
 ipc = ["flatbuffers"]
 simd = ["packed_simd"]
 prettyprint = ["prettytable-rs"]
+# enable features that rely on std
+std = ["rand/std", "rand/std_rng"]

Review comment:
       I am not sure about this one -- I needed to conditionally pull in the `rand` crate features that rely on `std` as it is needed for the `arrow-pyarrow-integration-testing` -- something about how `maturin` builds arrow requires the std features of rand (seems to build the tests as well)
   
   However, if we use the default features of rand then we can't build for wasm anymore 🤔 
   
   @jorgecarleitao  I am not sure if 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org