[GitHub] [nifi] markap14 commented on issue #3513: NIFI-4406 Updated ExecuteScript to use Searchable.

[GitBox <gi...@apache.org>]

markap14 commented on issue #3513: NIFI-4406 Updated ExecuteScript to use Searchable.
URL: https://github.com/apache/nifi/pull/3513#issuecomment-505930658
 
 
   Hey @MikeThomsen thanks for submitting the PR. Sorry it's taken me so long to get around to reviewing it! I did a quick test and it does work correctly. However, I'm a bit concerned about the fact that it returns the entire script body if it matches. While this is the same behavior if the "Script Body" property is set, I feel like if a file is specified, there's a much higher likelihood that the script is quite large. What do you think about only returning the line in the script that matches? Or, rather, a match for each line in the script body that matches?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services